Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @sentry/[email protected] as peer dependency (Angular 17) #508

Closed
sebsoftpak opened this issue Nov 21, 2023 · 2 comments
Closed

Allow @sentry/[email protected] as peer dependency (Angular 17) #508

sebsoftpak opened this issue Nov 21, 2023 · 2 comments

Comments

@sebsoftpak
Copy link

sebsoftpak commented Nov 21, 2023

Environment

"@sentry/angular-ivy": "7.77.0",
"@sentry/browser": "7.77.0",
"@sentry/capacitor": "^0.14.0",
"@sentry/tracing": "7.77.0",

Steps to Reproduce

  1. Upgraded the app to Angular 17, NGRX 17, and so on...
  2. Upgrade @sentry/ plugins to 7.77.0, the first version "supporting" Angular 17.

Expected Result

Can't use @sentry/[email protected] yet, because of peer dependency issue.
Could you please bump the version in the peer dependencies?
This seems to be the last plug-in preventing us from finishing the upgrade to Angular 17.

Actual Result

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @sentry/[email protected]
npm ERR! Found: @sentry/[email protected]
npm ERR! node_modules/@sentry/angular-ivy
npm ERR! @sentry/angular-ivy@"7.77.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional @sentry/angular-ivy@"7.73.0" from @sentry/[email protected]
npm ERR! node_modules/@sentry/capacitor
npm ERR! @sentry/capacitor@"^0.14.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @sentry/[email protected]
npm ERR! node_modules/@sentry/angular-ivy
npm ERR! peerOptional @sentry/angular-ivy@"7.73.0" from @sentry/[email protected]
npm ERR! node_modules/@sentry/capacitor
npm ERR! @sentry/capacitor@"^0.14.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@krystofwoldrich
Copy link
Member

Thank you for the message, we made the bump recently it will be released soon.

@lucas-zimerman
Copy link
Collaborator

Closed as the new version was released.

@github-project-automation github-project-automation bot moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants