Expand build process

Author: dcramer

.travis.yml

@@ -1,22 +1,32 @@
 sudo: false
 language: python
 services:
+  - memcached
+  - postgresql
   - redis-server
 python:
-  - "2.7"
+  - '2.7'
 cache:
   directories:
     - node_modules
-    - $HOME/.cache/pip
-    - "$HOME/virtualenv/python2.7.9"
+    - "$HOME/.cache/pip"
+deploy:
+  provider: pypi
+  user: getsentry
+  password:
+    secure: kVmxKHkBWRLYyZme05p+WZSJmb8GjHV9uyuaSCVMRlqWCW+GXRB7P1xXR2jb9URTlNdcs56Ab/UrwzCbMFGC8LmwCeFVgIR/ltytVZG2FgXZPWaeA4dH25qK2oGWgzJ/xeiMpmuJqN9hRl25MX6jG7FZKvrrOkG7+8tpPd1yO+uYWZQbnebZMjcPBqEpn7CC0hR39GSoyVAbydpMe5hwENGQM26CepcicdrelfawItoUrXrkJzBHkIQQTO/xRSbCtRJOtzI5lwtv3GP0hcbOy5tI5dhG/93pLwZRc5+dZaCaP7oaVeOcBjN0zfINRQobt8d6h2Qgvd/YyFkGi0/xKn1zMmKIVLOG6VsYwEAUq8wNOsP4A/jdm4Y0J/1oEZStCkpaGpx85TYi4kq1hWQdyqaVJSPhh4Tk4roIaS2zOYQl+nIpbHqmJ4FJrg1il+TCdjBXobATQ1mKRBUrjD+RDzH/r4ogbd8+UwvvvevpqS2K+/wgT6UD0MzDInv9S29CUQvuFhPoqyJb5XRddHMRE9EEK/2Z8tFN91sDATnqfXHgwnvu00q/nKP5JnijBPzGmx7ydgUViIukklDrlPvo9BbRJz0Vr2vbAvMTrLMLCXqi5CwTm+v+iaOf/YaCziaG2vx0eVASYjpOLCedSgRZBubPM8z4E/HMXhChN7sVDWk=
+  on:
+    tags: true
+  distributions: sdist bdist_wheel
 env:
   global:
-    - SENTRY_LIGHT_BUILD=1
-    - SKIP_BACKEND_VALIDATION=1
+    - PIP_DOWNLOAD_CACHE=".pip_download_cache"
+before_install:
+  - pip install codecov
 install:
-  - pip install -e .
-  - pip install "file://`pwd`#egg=sentry-auth-github[tests]"
+  - make develop
 script:
-  - py.test
+  - PYFLAKES_NODOCTEST=1 flake8
+  - coverage run --source=. -m py.test tests
 after_success:
   - codecov

LICENSE

@@ -186,7 +186,7 @@ APPENDIX: How to apply the Apache License to your work.
    same "printed page" as the copyright notice for easier
    identification within third-party archives.
 
-Copyright 2015 Functional Software, Inc.
+Copyright 2016 Functional Software, Inc.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

Makefile

@@ -1,4 +1,26 @@
-test:
+.PHONY: clean develop install-tests lint publish test
+
+develop:
+	pip install "pip>=7"
 	pip install -e .
-	pip install "file://`pwd`#egg=sentry-auth-github[tests]"
-	py.test -x
+	make install-tests
+
+install-tests:
+	pip install .[tests]
+
+lint:
+	@echo "--> Linting python"
+	flake8
+	@echo ""
+
+test:
+	@echo "--> Running Python tests"
+	py.test tests || exit 1
+	@echo ""
+
+publish:
+	python setup.py sdist bdist_wheel upload
+
+clean:
+	rm -rf *.egg-info src/*.egg-info
+	rm -rf dist build

sentry_auth_github/client.py

@@ -3,7 +3,6 @@
 from requests.exceptions import RequestException
 from sentry import http
 from sentry.utils import json
-from urllib import urlencode
 
 from .constants import API_DOMAIN
 

sentry_auth_github/provider.py

@@ -1,12 +1,9 @@
 from __future__ import absolute_import, print_function
 
-from collections import namedtuple
-from django.conf import settings
 from sentry.auth.exceptions import IdentityNotValid
 from sentry.auth.providers.oauth2 import (
     OAuth2Callback, OAuth2Provider, OAuth2Login
 )
-from urllib import urlencode
 
 from .client import GitHubApiError, GitHubClient
 from .constants import (
@@ -86,6 +83,6 @@ def refresh_identity(self, auth_identity):
 
         try:
             if not client.is_org_member(access_token, self.org['id']):
-                raise IdentityNotValid(e)
+                raise IdentityNotValid
         except GitHubApiError as e:
             raise IdentityNotValid(e)

sentry_auth_github/views.py

@@ -102,6 +102,7 @@ def handle(self, request, helper):
             'form': form,
         })
 
+
 class SelectOrganizationForm(forms.Form):
     org = forms.ChoiceField(label='Organization')
 

setup.cfg

@@ -1,12 +1,12 @@
+[wheel]
+universal = 1
+
 [pytest]
-python_files=test*.py
-addopts=--tb=native
-norecursedirs=bin dist docs	htmlcov script hooks node_modules .* {args}
+python_files = test*.py
+addopts = --tb=native -p no:doctest
+norecursedirs = bin dist docs htmlcov script hooks node_modules .* {args}
 
 [flake8]
-ignore = F999,E501,E128,E124,E402,W503,E731,F841
+ignore = F999,E501,E128,E124,E402,W503,E731,C901
 max-line-length = 100
-exclude = .tox,.git,docs/*
-
-[wheel]
-universal = 1
+exclude = .tox,.git,*/migrations/*,node_modules/*,docs/*

setup.py

@@ -3,29 +3,29 @@
 sentry-auth-github
 ==================
 
-:copyright: (c) 2015 Functional Software, Inc
+:copyright: (c) 2016 Functional Software, Inc
 """
 from setuptools import setup, find_packages
 
 
-tests_require = [
-    'pytest',
-    'mock',
+install_requires = [
+    'sentry>=7.0.0',
 ]
 
-install_requires = [
-    'sentry',
+tests_require = [
+    'mock',
+    'flake8>=2.0,<2.1',
 ]
 
 setup(
     name='sentry-auth-github',
     version='0.1.0',
-    author='David Cramer',
-    author_email='dcramer@gmail.com',
+    author='Sentry',
+    author_email='support@getsentry.com',
     url='https://www.getsentry.com',
     description='GitHub authentication provider for Sentry',
     long_description=__doc__,
-    license='',
+    license='Apache 2.0',
     packages=find_packages(exclude=['tests']),
     zip_safe=False,
     install_requires=install_requires,
@@ -35,7 +35,7 @@
     entry_points={
         'sentry.apps': [
             'auth_github = sentry_auth_github',
-         ],
+        ],
     },
     classifiers=[
         'Intended Audience :: Developers',