From 6e303aa4fbaed3693f10dd8675cf7b05fa8d7185 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yoshioka=20Tsuneo=20=28=E5=90=89=E5=B2=A1=20=E6=81=92?= =?UTF-8?q?=E5=A4=AB=29?= Date: Mon, 17 Feb 2025 23:40:29 +0900 Subject: [PATCH] Fix height for mobile safari not to overlap URL bar --- client/app/assets/css/login.css | 2 +- client/app/assets/less/inc/base.less | 4 ++-- client/app/assets/less/inc/login.less | 4 ++-- client/app/assets/less/redash/query.less | 4 ++-- .../ApplicationArea/ApplicationLayout/index.less | 8 ++++++-- client/app/pages/dashboards/PublicDashboardPage.less | 2 +- 6 files changed, 14 insertions(+), 10 deletions(-) diff --git a/client/app/assets/css/login.css b/client/app/assets/css/login.css index cf46eefb0c..1120ec1e7c 100644 --- a/client/app/assets/css/login.css +++ b/client/app/assets/css/login.css @@ -15,7 +15,7 @@ body { display: table; width: 100%; padding: 10px; - height: calc(100vh - 116px); + height: calc(100% - 116px); } @media (min-width: 992px) { diff --git a/client/app/assets/less/inc/base.less b/client/app/assets/less/inc/base.less index 14a37f3470..80dc02e81d 100755 --- a/client/app/assets/less/inc/base.less +++ b/client/app/assets/less/inc/base.less @@ -20,7 +20,7 @@ html { html, body { - min-height: 100vh; + height: 100%; } body { @@ -35,7 +35,7 @@ body { } #application-root { - min-height: 100vh; + height: 100%; } #application-root, diff --git a/client/app/assets/less/inc/login.less b/client/app/assets/less/inc/login.less index 81ee077790..a820159350 100755 --- a/client/app/assets/less/inc/login.less +++ b/client/app/assets/less/inc/login.less @@ -10,7 +10,7 @@ vertical-align: middle; display: inline-block; width: 1px; - height: 100vh; + height: 100%; } } @@ -135,4 +135,4 @@ } } - \ No newline at end of file + diff --git a/client/app/assets/less/redash/query.less b/client/app/assets/less/redash/query.less index 57bccbc8c4..6a5e872fc6 100644 --- a/client/app/assets/less/redash/query.less +++ b/client/app/assets/less/redash/query.less @@ -8,7 +8,7 @@ body.fixed-layout { padding-bottom: 0; width: 100vw; - height: 100vh; + height: 100%; .application-layout-content > div { display: flex; @@ -90,7 +90,7 @@ body.fixed-layout { .embed__vis { display: flex; flex-flow: column; - height: calc(~'100vh - 25px'); + height: calc(~'100% - 25px'); > .embed-heading { flex: 0 0 auto; diff --git a/client/app/components/ApplicationArea/ApplicationLayout/index.less b/client/app/components/ApplicationArea/ApplicationLayout/index.less index 8da48be1af..74074f686e 100644 --- a/client/app/components/ApplicationArea/ApplicationLayout/index.less +++ b/client/app/components/ApplicationArea/ApplicationLayout/index.less @@ -7,10 +7,10 @@ body #application-root { flex-direction: row; justify-content: stretch; padding-bottom: 0 !important; - height: 100vh; + height: 100%; .application-layout-side-menu { - height: 100vh; + height: 100%; position: relative; @media @mobileBreakpoint { @@ -47,6 +47,10 @@ body #application-root { } } +body > section { + height: 100%; +} + body.fixed-layout #application-root { .application-layout-content { padding-bottom: 0; diff --git a/client/app/pages/dashboards/PublicDashboardPage.less b/client/app/pages/dashboards/PublicDashboardPage.less index ed03e4f4f8..51c36549a3 100644 --- a/client/app/pages/dashboards/PublicDashboardPage.less +++ b/client/app/pages/dashboards/PublicDashboardPage.less @@ -8,7 +8,7 @@ } > .container { - min-height: calc(100vh - 95px); + min-height: calc(100% - 95px); } .loading-message {