Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Porter Build to Not Push Docker Image #354

Closed
jeremyrickard opened this issue May 20, 2019 · 0 comments · Fixed by #365
Closed

Update Porter Build to Not Push Docker Image #354

jeremyrickard opened this issue May 20, 2019 · 0 comments · Fixed by #365

Comments

@jeremyrickard
Copy link
Contributor

jeremyrickard commented May 20, 2019 •
edited
Loading

The security spec aspect of CNAB is still in flux and the use of digests isn't fixed. We should update Porter to remove the dependency on updating the digest on a build.

The push of the image and injection of a digest should really be a result of signing/publishing the bundle, so we can address this later with that. See #254 for more context on publishing.
jeremyrickard added a commit to jeremyrickard/porter that referenced this issue May 30, 2019
@jeremyrickard
Migrate invocation image push to porter publish
e17f195 
Closes: getporter#354
@jeremyrickard jeremyrickard mentioned this issue May 30, 2019
Merged
jeremyrickard added a commit that referenced this issue May 30, 2019
@jeremyrickard
Migrate invocation image push to porter publish (#365)
75bb688 
* Migrate invocation image push to `porter publish`

Closes: #354

* Fixed a test oversight

* Udpated docs

* YOU TAGGED THE WRONG THING JEREMY

* Resolve review comments

* Wrap the error in validation

* Update error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate invocation image push to porter publish jeremyrickard/porter
1 participant
@jeremyrickard