Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render links for XLSForm warning URLs #687

Closed
matthew-white opened this issue Jan 4, 2023 · 5 comments · Fixed by #685
Closed

Render links for XLSForm warning URLs #687

matthew-white opened this issue Jan 4, 2023 · 5 comments · Fixed by #685
Assignees
@sadiqkhoja
Labels
behavior verified Behavior has been manually verified enhancement New feature or behavior

Comments

@matthew-white
Copy link
Member

A few XLSForm warnings end with "Learn more: [some URL]". Currently, we don't linkify that URL: it is rendered as text. However, it would be helpful if we rendered a link instead.
@matthew-white matthew-white added the enhancement New feature or behavior label Jan 4, 2023
@matthew-white matthew-white linked a pull request Jan 4, 2023 that will close this issue
Enhance #439 & #616: Show workflow warnings #685
Merged
@lognaturel
Copy link
Member

lognaturel commented Jan 6, 2023 •
edited
Loading

Well that's cool! I see from https://github.com/getodk/central-frontend/pull/685/files#diff-297d623ca753d07d496717ce4e92f55d4a3f4a6398a40b2be246c3b53e858bdcR257 that this is specifically looking for a "Learn more:" prefix which is not necessarily consistently used in pyxform. We should probably make this a documented pattern if we're going to rely on it, right?

Why not linkify all URLs?

@sadiqkhoja
Copy link
Contributor

I want to make all links consistent in warning box:

image

I searched for xlsform.org in pyxform repository (https://github.com/XLSForm/pyxform/search?q=xlsform.org) and found that all the help links have "Learn more" prefix, is there any other patter?

@lognaturel
Copy link
Member

is there any other patter

No. But this one is not documented. XLSForm/pyxform#634

@matthew-white matthew-white added the needs testing Needs manual testing label Jan 10, 2023
@matthew-white matthew-white mentioned this issue Jan 26, 2023
Open
@srujner
Copy link

srujner commented Jan 27, 2023

Tested with Success!

1 similar comment
@dbemke
Copy link

dbemke commented Jan 27, 2023

Tested with Success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sadiqkhoja sadiqkhoja

Labels
behavior verified Behavior has been manually verified enhancement New feature or behavior
Projects
ODK Central
Status: ✅ done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance #439 & #616: Show workflow warnings sadiqkhoja/central-frontend
5 participants
@sadiqkhoja @lognaturel @matthew-white @dbemke @srujner