Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Put a timeout to the check for updates call #823

Open
ggalmazor opened this issue Oct 3, 2019 · 2 comments
Open

Put a timeout to the check for updates call #823

ggalmazor opened this issue Oct 3, 2019 · 2 comments

Comments

@ggalmazor
Copy link
Contributor

Problem description

Briefcase gets stuck checking for updates for different network reasons (firewall, custom dns, lack of connectivity...) or if GH service is down.

Steps to reproduce the problem

  • Edit the /etc/hosts conf file and create an entry for api.github.com pointing an IP address that won't respond HTTP calls such as 1.2.3.4
  • Launch Briefcase

Expected behavior

The update notice should disappear after some time.

Additionally, we could consider showing a message telling the user that Briefcase can't check for updates.

Other information

Forum thread at https://forum.opendatakit.org/t/update-notice-keeps-checking-for-updates/22475

@macdude357
Copy link
Contributor

I can take a look at fixing this.

@macdude357
Copy link
Contributor

macdude357 commented Nov 4, 2019

In looking at this I also found that the update request might return an HTTP 200 but the body would be a message that the API rate limit has been exceeded. So the code should also check for that as well. Do you want the timeout to be configurable or should it simply be a hardcoded value (say 30 seconds)?

Also, I assume you want to update the label that says "checking for updates..." to say something like "Checking for updates failed."

@ggalmazor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants