Skip to content

Commit

Permalink
Fix #238 by making Construct Json Req non-pure
Browse files Browse the repository at this point in the history
Constructing a request should happen before other calls, made non-pure. Should make #238 cases less common.
  • Loading branch information
getnamo committed Dec 14, 2020
1 parent 8bd072f commit a8d593d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion SocketIOClient.uplugin
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"FileVersion": 3,
"Version": 1,
"VersionName": "1.5.0",
"VersionName": "1.5.1",
"EngineVersion" : "4.26.0",
"FriendlyName": "Socket.IO Client",
"Description": "Real-time networking library Socket.IO Client usable from blueprints and c++.",
Expand Down
4 changes: 2 additions & 2 deletions Source/SIOJson/Public/SIOJRequestJSON.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,11 @@ class SIOJSON_API USIOJRequestJSON : public UObject
// Construction

/** Creates new request (totally empty) */
UFUNCTION(BlueprintPure, meta = (DisplayName = "Construct Json Request (Empty)", HidePin = "WorldContextObject", DefaultToSelf = "WorldContextObject"), Category = "SIOJ|Request")
UFUNCTION(BlueprintCallable, meta = (DisplayName = "Construct Json Request (Empty)", HidePin = "WorldContextObject", DefaultToSelf = "WorldContextObject"), Category = "SIOJ|Request")
static USIOJRequestJSON* ConstructRequest(UObject* WorldContextObject);

/** Creates new request with defined verb and content type */
UFUNCTION(BlueprintPure, meta = (DisplayName = "Construct Json Request", HidePin = "WorldContextObject", DefaultToSelf = "WorldContextObject"), Category = "SIOJ|Request")
UFUNCTION(BlueprintCallable, meta = (DisplayName = "Construct Json Request", HidePin = "WorldContextObject", DefaultToSelf = "WorldContextObject"), Category = "SIOJ|Request")
static USIOJRequestJSON* ConstructRequestExt(UObject* WorldContextObject, ESIORequestVerb Verb, ESIORequestContentType ContentType);

/** Set verb to the request */
Expand Down

0 comments on commit a8d593d

Please sign in to comment.