Avoid is_readable check when possible

[bnomei]

Description

The is_readable function seems innocent but since it checks the file on the disk it has a noticable impact on performance when execute thousands of times. My suggestion would be to delay it and just try and fail. This will improve the read function speed about 30-40% based on my tests – which is huge imho.

current

public static function read(string $file): string|false
	{
		if (
			is_readable($file) !== true &&
			Str::startsWith($file, 'https://') !== true &&
			Str::startsWith($file, 'http://') !== true
		) {
			return false;
		}

		return file_get_contents($file);
	}

proposed

public static function read(string $file): string|false
	{
		if (
			Str::startsWith($file, 'https://') !== true &&
			Str::startsWith($file, 'http://') !== true
		) {
			return false;
		}

		try { 
                    return file_get_contents($file);
                } catch (Exception $ex) {
                    return false;
                }
	}

kirby/src/Filesystem/F.php

Line 612 in a0e64e8

public static function read(string $file): string|false

[bastianallgeier]

I've added a PR for this. We need to add @ to surpress warnings. #7099 @bnomei could you run another performance test on this. I don't think the @ operator should have any negative effect, but who knows :)

[bnomei]

@bastianallgeier used the code from your PR in my 20k pages test setup and got 3-4% total performance boost and like i measured before 30-40% inside the F::read itself.

[bnomei]

btw the file_exists in PlainTextStorage::read/exists are similar calls, (most likely) avoidable assuming they do exist in most cases and fail when the read fails... they amount to 2-4% total wall time in my test suite.