Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Language selector still visible for single language app #6850

Closed
afbora opened this issue Dec 9, 2024 · 3 comments · Fixed by #6857
Closed

[v5] Language selector still visible for single language app #6850

afbora opened this issue Dec 9, 2024 · 3 comments · Fixed by #6857
Assignees
Milestone

Comments

@afbora
Copy link
Member

afbora commented Dec 9, 2024

When single language environment:

  • Language selector visible (was not visible for 4.x)
  • Also visible unnecessary separate line under default language (ignore this if we remove the selector entirely for single language)

5 0 0 test_panel_pages_notes+exploring-the-universe

@tobimori
Copy link
Contributor

tobimori commented Dec 9, 2024

man you were 55 minutes faster than me :(

@distantnative
Copy link
Member

@afbora Does it work when you change https://github.com/getkirby/kirby/blob/v5/develop/src/Panel/Ui/Buttons/LanguagesDropdown.php#L114 to

		if ($this->kirby->languages()->count() < 2) {

@afbora
Copy link
Member Author

afbora commented Dec 9, 2024

@distantnative Yes, it works.

@afbora afbora self-assigned this Dec 10, 2024
@afbora afbora linked a pull request Dec 10, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants