-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setDeepLinkingEnabled has no effect #15
Comments
Hey @KestasVenslauskas , deep linking will only work after the proper deep link registering within your application. |
@edgar-zigis I had the proper deepLink setup from previous examples it was "kevin://" I tought it works because I left it there and callback urls matched the schema but after removing intent-filters from androids manifest and changing callback url it was still working the same. What would be the use case or advantage to have a proper deepLink setup right now? |
@edgar-zigis Just tried with my own deepLinking setup. Changing this flag tries to open a deepLink even if 'deepLinkingEnabled' is false. Also I think deepLinking is not working as expected because another instance of my app is opened from deep link instead going back to the same app instance and passing intent result. |
@KestasVenslauskas hi! Since our current example does not support account linking yet (we are working on a new refactored example app), I tested deep linking with in app payments. In flutter's app main() method I added: await Kevin.setDeepLinkingEnabled(true);
await KevinPayments.setPaymentsConfiguration(
const KevinPaymentsConfiguration(
callbackUrl: 'kevin://redirect.payment',
),
); In flutter's app android manifest file: <activity
android:name="eu.kevin.inapppayments.paymentsession.PaymentSessionActivity"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.VIEW" />
<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />
<data
android:host="redirect.payment"
android:scheme="kevin" />
</intent-filter>
</activity> Then I proceeded to make a payment using Revolut bank. After the payment, redirect link was opened and example app existing instance was opened as well. Could you share some code snippets with your deep linking setup, so I could investigate it later? |
@antons-zubkovs Since I did not used an example app, but just double checked the code I tested both accountLinking & in-app-payments. Both works fine. About the deep linking... I tested few links and behaviour is still strange.
I cannot fully test deep linking because of the points mentioned above but the other question is what is the expected flow here? Is it actually needed? I wonder what happens when deepLinkingEnabled is set to false but I will pass callbackUrl as my deepLink url? |
|
@antons-zubkovs As I understand What I'm trying to achieve here is simply callback to our backend for a successfull payment, which does not actually require deepLinking here since this SDK automatically goes back to the app if links match, so then I can send a request to the backend from a client app after the callback from Kevin SDK is received in flutter code. |
@KestasVenslauskas regarding The way to achieve your desired behaviour - you can have some endpoint on your BE to confirm that the payment was finished, when you get the result from the flutter plugin. |
@antons-zubkovs Just tried |
@KestasVenslauskas it tried to open SwedBank app, though it does not support it, that's why flow was continued in a web view. You can try to check it with Revolut bank with/without |
@antons-zubkovs I do have a Revolut on my device. Just tried with |
@KestasVenslauskas did you set |
@antons-zubkovs No if I set |
@KestasVenslauskas that also could be the reason, yes. |
As I was testing on Android & iOS I think I didnt find a purpose for 'setDeepLinkingEnabled' method.
Yes it sets this flag in code package and also calls native method to set the flat on native SDK itself, but what is the usecase for this?
I can actually set auth & payment redirect urls as
https://www.google.com
and the flow will still ignore this. Looking on android code it makes sense because it does not even look at redirect url since it uses activity result from AccountSessionActivity. Maybe 'deepLinkingEnabled' flag is used somewhere internally on Kevin native SDK's but is this even required here to be exposed in flutter package?It's great that we do not need to setup deepLinking manually but is this intended not to have option for any other redirect url?
The text was updated successfully, but these errors were encountered: