Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title and state user attributes skipped during user creation #281

Open
jgonyea opened this issue Oct 4, 2021 · 0 comments
Open

Title and state user attributes skipped during user creation #281

jgonyea opened this issue Oct 4, 2021 · 0 comments

Comments

@jgonyea
Copy link
Contributor

jgonyea commented Oct 4, 2021

Possible bug during account creation via the CLI.

To reproduce:

Provide any parameters during the initial call bin/plugin login new-user

Expected behavior:

All "required" fields should prompt and not skip during account creation, unless that parameter is provided during the initial cli command.

Observed behavior:

  • title field is skipped and defaults to null
  • state field is skipped and defaults to enabled

I believe the behavior is resulting from the second part of each conditional:
if (!$this->options['title'] && !count(array_filter($this->options))) {
and
if (!$this->options['state'] && !count(array_filter($this->options))) {

Proposed fix:

Remove the second conditional of the counting of the options passed into the cli command.

@jgonyea jgonyea changed the title Title attribute skipped during user creatinon Title and state user attributes skipped during user creatinon Oct 4, 2021
@jgonyea jgonyea changed the title Title and state user attributes skipped during user creatinon Title and state user attributes skipped during user creation Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant