Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using security@ with tabs breaks navigation #524

Open
robertbak opened this issue Aug 3, 2021 · 1 comment · May be fixed by #525
Open

Using security@ with tabs breaks navigation #524

robertbak opened this issue Aug 3, 2021 · 1 comment · May be fixed by #525

Comments

@robertbak
Copy link

If a tab is hidden, the tabs following it in the bar don't work correctly.

How to reproduce:

  1. Create a page blueprint (eg. user/blueprints/pages/default.yaml) with:
"@extends":
  type: default
  context: blueprints://pages
form:
  fields:
    tabs:
      type: tabs
      active: 1
      fields:
        advanced:
          security@: admin.foobar
  1. In the admin panel open a page using that blueprint, try clicking "Security". It won't switch to that.
robertbak added a commit to robertbak/grav-plugin-form that referenced this issue Aug 3, 2021
@robertbak
Use tab field name instead of loop.index for navigation.
3f4a6ae 
When tabs are hidden using the security@ feature, loop.index doesn't
match between tabs-nav and tabs-content
Fixes getgrav#524
@robertbak robertbak linked a pull request Aug 3, 2021 that will close this issue
Open
@robertbak
Copy link
Author

Hi, just a reminder that this is still an issue, and it's an annoying one, because securing the advanced tab content only causes the next tab (Security) usually to display the advanced tab content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use tab field name instead of loop.index for navigation robertbak/grav-plugin-form
1 participant
@robertbak