-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nothing gets rendered - grav.twig.enable appears obsolete #75
Comments
I'm not actually seeing that statement, only My comments are not only not rendering, now, but all previous comments seem to have been deleted, so I am grasping at straws here. |
I had Replacing it by I still have to find about the POST function not working, and eventually see if submitted comments are showing up then. |
@diagone3000 and @jeremycherfas : Any news ? |
in comments.html.twig replace
to this
The form will then show up. However it still have some issues, like button name and the fact that it does not save the comments |
@Romarain Yes, that was the line. However, since my post I have done some test, with the default template, and the comment plugin seems to work. So need to do some more debugging why with other templates there is an issue. I did the test using latest GRAV 1.6.8 |
@sospcie Hi. I'm actually trying to make that plugin to work, and can't.
and it shows the form. But no matter I send the message, it isn't saved. I've looked into the /data folder, nothing is there. |
To make the comments POST, "grav."part should be removed from the pages upper section eg. grav.config.plugins.comments.form.action => config.plugins.comments.form.action, and so on
|
@Kalmera74 Unfortunately, this doesn't change anything. I've replace all the occurences in my custom |
@Romarain There should be no need to edit the php file only editing the twig file sould have been enough. It is possible that your theme is also the part of the problem, but I am not sure. |
@Kalmera74 Do you use the |
I had an issue with the comment code not showing up on the item page. After I did the below, it showed up.
but then when I entered and submitted a comment no comment appeared in Admin, nothing in data/comments. I then tried the below (removing grav. from everywhere in the twig file) and that also did not solve anything.
Then I commented out the enable_on_routes: - also no comments posted I've added email from/to to Email plugin. (however, I would think this would only have anything to do with the email and not with storing the comment). Any other ideas? I am on localhost with the default Quark theme. UPDATE: it does look like it has something to do with the email not functioning. If I disabled Email plugin, all works as expected. |
I tested by just removing the form |
I'm struggling with this problem now. Tried all of the above, even removing the email field and disabling the email plugin but it's still not working - the form displays, but submitting a comment doesn't seem to do anything. |
Granted, this was written before we had a lot of helper functions, but it does work even in latest Grav 1.7 with:
|
The sample comments.html.twig shows:
{% if grav.twig.enable %}
Which never is set even when twig is enabled in config/system.yaml
I was able to make the comments come up by deleting the
{% if grav.twig.enable %}
and it's corresponding{% endif %}
The text was updated successfully, but these errors were encountered: