Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multisite-setup, setup.php plugins key does not allow disabling plugins #959

Open
drzraf opened this issue Dec 9, 2021 · 4 comments
Open

Comments

@drzraf
Copy link

drzraf commented Dec 9, 2021

https://github.com/getgrav/grav-learn/blob/develop/pages/08.advanced/05.multisite-setup/docs.17.md
indicates that user/setup.php could do something like:

return [
    'plugins' => []
];

I tried:

return [
    'plugins' => [
        'problems' => [
            'enabled' => 'false'
        ],
        'git-sync' => [
            'enabled' => 'false'
        ]
    ],

... in order to disable a set of plugins, without success.

Whether or not this is supported, this must be documented.
Note: I couldn't find the necessary codebase references to dig for the underlying logic.

@mahagr
Copy link
Member

mahagr commented Dec 10, 2021

Setup is not meant to do that. It just initializes the system so that everything loads from the right place -- including the configuration. Configuration files that get loaded later will override everything in the setup.

@drzraf
Copy link
Author

drzraf commented Dec 13, 2021

Yeah, but it's documented it could already do that (= configure plugins):

Screenshot from 2021-12-13 11-29-41

So one would expect it could disable plugins too.

@mahagr
Copy link
Member

mahagr commented Dec 14, 2021

No, even that won't work if you override the keys. Besides above example has been superseded with a better solution anyways.

@drzraf
Copy link
Author

drzraf commented Dec 14, 2021

Could you please remove that misleading chunk from the documentation and put the better solution? I'm interested knowing what best practices are advised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants