Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version built with Go 1.22.x #2517

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

chadlwilson
Copy link
Contributor

Bumps some versions of tools used in the release process to latest LTS.

Note this will trigger release of v1.6.4...master

Input from @sriv or @haroon-sheikh appreciated!

@gaugebot
Copy link

gaugebot bot commented Apr 2, 2024

@chadlwilson Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@chadlwilson chadlwilson enabled auto-merge (squash) April 2, 2024 04:01
@haroon-sheikh
Copy link
Contributor

Lgtm 👍 let's try to do these version update release every quarter.

Id also like to include this change as part of 1.4.5 #2512

@chadlwilson chadlwilson disabled auto-merge April 2, 2024 04:18
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Benchmark Results

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
e1b8dd9 65% 245688 0:17.74 0
44ebad3 66% 210124 0:16.84 0
a550d71 58% 242188 0:19.28 0
fdb613b 78% 238080 0:14.66 0

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
e1b8dd9 24% 72016 0:22.87 0
44ebad3 24% 71404 0:23.26 0
a550d71 21% 71984 0:25.67 0
fdb613b 23% 72108 0:23.59 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
e1b8dd9 53% 67896 0:11.58 0
44ebad3 48% 69940 0:12.77 0
a550d71 53% 67672 0:11.35 0
fdb613b 53% 71664 0:11.33 0

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
e1b8dd9 10% 119588 0:22.49 0
44ebad3 9% 120368 0:23.62 0
a550d71 9% 122548 0:23.36 0
fdb613b 9% 120844 0:22.49 0

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
e1b8dd9 40% 237048 0:33.03 0
44ebad3 43% 241196 0:30.34 0
a550d71 43% 229944 0:30.54 0
fdb613b 41% 229184 0:33.78 0

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
e1b8dd9 34% 65960 0:10.23 0
44ebad3 25% 68024 0:14.01 0
a550d71 29% 67584 0:12.32 0
fdb613b 36% 69752 0:09.83 0

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
e1b8dd9 9% 120024 0:26.14 0
44ebad3 9% 121916 0:25.68 0
a550d71 9% 117132 0:25.04 0
fdb613b 9% 109284 0:26.09 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
e1b8dd9 5% 120188 0:41.12 0
44ebad3 5% 121144 0:45.50 0
a550d71 6% 118652 0:37.12 0
fdb613b 5% 127628 0:44.26 0

java_maven_serial.csv

Commit CPU Memory Time ExitCode
e1b8dd9 75% 234640 0:19.04 0
44ebad3 81% 233976 0:18.09 0
a550d71 65% 262860 0:21.77 0
fdb613b 81% 205484 0:17.80 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

@chadlwilson chadlwilson enabled auto-merge (squash) April 2, 2024 05:32
Apparently no longer need to do this HEAD^2 stuff according to warning on the actions. "1 issue was detected with this workflow: git checkout HEAD^2 is no longer necessary. Please remove this step as Code Scanning recommends analyzing the merge commit for best results."

Signed-off-by: Chad Wilson <[email protected]>
Signed-off-by: Chad Wilson <[email protected]>
@chadlwilson chadlwilson merged commit aca081e into getgauge:master Apr 2, 2024
28 checks passed
@haroon-sheikh
Copy link
Contributor

@chadlwilson just in case you haven’t seen already, the pypi release step is failing.

@chadlwilson chadlwilson deleted the version-bumps branch April 2, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants