Skip to content

Commit

Permalink
Use ExecuteAndGetStatus to deliver Concept Start and End notification
Browse files Browse the repository at this point in the history
Signed-off-by: Piotr Nestorow <[email protected]>
  • Loading branch information
PiotrNestor committed Feb 14, 2024
1 parent 47ff86b commit af22569
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions execution/scenarioExecutor.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,14 +145,14 @@ func (e *scenarioExecutor) notifyBeforeConcept(conceptResult *result.ScenarioRes
message := &gauge_messages.Message{MessageType: gauge_messages.Message_ConceptExecutionStarting,
ConceptExecutionStartingRequest: &gauge_messages.ConceptExecutionStartingRequest{CurrentExecutionInfo: e.currentExecutionInfo, Stream: int32(e.stream)}}
e.pluginHandler.NotifyPlugins(message)
e.runner.ExecuteMessageWithTimeout(message)
_ = e.runner.ExecuteAndGetStatus(message)
}

func (e *scenarioExecutor) notifyAfterConcept(conceptResult *result.ScenarioResult) {
message := &gauge_messages.Message{MessageType: gauge_messages.Message_ConceptExecutionEnding,
ConceptExecutionEndingRequest: &gauge_messages.ConceptExecutionEndingRequest{CurrentExecutionInfo: e.currentExecutionInfo, Stream: int32(e.stream)}}
e.pluginHandler.NotifyPlugins(message)
e.runner.ExecuteMessageWithTimeout(message)
_ = e.runner.ExecuteAndGetStatus(message)
}

func (e *scenarioExecutor) createStepRequest(protoStep *gauge_messages.ProtoStep) *gauge_messages.ExecuteStepRequest {
Expand Down
2 changes: 1 addition & 1 deletion runner/grpcRunner.go
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ func (r *GrpcRunner) ExecuteAndGetStatus(m *gm.Message) *gm.ProtoExecutionResult
}
return &gauge_messages.ProtoExecutionResult{Failed: true, ErrorMessage: err.Error()}
}
return res.ExecutionStatusResponse.ExecutionResult
if res != nil { return res.ExecutionStatusResponse.ExecutionResult } else { return nil }
}

// Alive check if the runner process is still alive
Expand Down

0 comments on commit af22569

Please sign in to comment.