Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken check of valid base64 encoding of attached files #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix broken check of valid base64 encoding of attached files #12

wants to merge 2 commits into from

Conversation

matsolastrom
Copy link

Fixing the issue that PHP base64 encoding does not always work with the original preg_match.
Using PHPs own encode and decode functions ensure full compatibility.
This fixes #11

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matsolastrom
Copy link
Author

@preetishishodia7 can we please merge this?

@matsolastrom
Copy link
Author

Ping @preetishishodia7 ? Can this please be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base64 Encoded PDF Fails
1 participant
@matsolastrom