Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Handle sub sats invoices correctly #3264

Open
1 task done
reneaaron opened this issue Oct 29, 2024 · 1 comment · May be fixed by #3265
Open
1 task done

[BUG] Handle sub sats invoices correctly #3264

reneaaron opened this issue Oct 29, 2024 · 1 comment · May be fixed by #3265
Assignees
@pavanjoshi914

Comments

@reneaaron
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

https://athenut.com/topup seems to use sub-sat amounts in their invoices:

e.g. lnbc2090820p1pnjp7hrsp52nvfg9qufaw57c74h9n35hwrxmcyn27yf7e9hrcn8ux639yryk0qpp50t2xjm0dpy8lc74e68gannelm6q0yumkau6866usv742md6j2edqdqqxqrpcgcqpjrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glc7rf05uqqg8gqqqqqqqlgqqqqrucqjq9qxpqysgqsl4s2r4p3r4f7a2e0p67hvdkmq4ss904q2v3lt8qvmy5arh4jaxnnd8rszpsjxnj0unuweled5vv732dngdhatp8qhwgwccwk8drcxcqay02aq

When you paste this into the extension you will see an amount of 0.
image

Also the success screen looks quite odd:
image

Screenshots [optional]

No response

Steps To Reproduce

...

Expected behavior

...

Alby information

...

Device information

No response

Additional context

No response

Are you working on this?

None
@bumi
Copy link
Collaborator

bumi commented Oct 29, 2024

sub sats don't exist

@pavanjoshi914 pavanjoshi914 linked a pull request Nov 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavanjoshi914 pavanjoshi914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: handle sub sat amounts getAlby/lightning-browser-extension
3 participants
@bumi @pavanjoshi914 @reneaaron