Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for protocol and port in allowances #2437

Open
reneaaron opened this issue May 16, 2023 · 0 comments · May be fixed by #2930
Open

Check for protocol and port in allowances #2437

reneaaron opened this issue May 16, 2023 · 0 comments · May be fixed by #2930
Assignees
@pavanjoshi914
Labels
idea A feature idea that needs to be more specification

Comments

@reneaaron
Copy link
Contributor

Feature description

Currently allowances only consider the domain they are being created on regardless of the protocol or port being used.

Describe the solution

  • Include the fully qualified origin for allowances (maybe origin.domain could be used here instead of origin.host)
  • Migrate existing allowances (prefix with https)
  • Potentially display a warning on the enable screen when connecting to non-ssl domains (MITM)

Describe alternatives

No response

Additional context

No response

Are you working on this?

None
@reneaaron reneaaron added the idea A feature idea that needs to be more specification label May 16, 2023
@pavanjoshi914 pavanjoshi914 linked a pull request Dec 13, 2023 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavanjoshi914 pavanjoshi914

Labels
idea A feature idea that needs to be more specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: secure allowance creationby including protocol information getAlby/lightning-browser-extension
2 participants
@pavanjoshi914 @reneaaron