Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for pre closed and closed assumptions #2523

Open
holzeis opened this issue May 9, 2024 · 0 comments
Open

Add test for pre closed and closed assumptions #2523

holzeis opened this issue May 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@holzeis
Copy link
Contributor

holzeis commented May 9, 2024

These are fair assumptions, given that the PreClosed and Closed variants are supposed to refer to a force-closed channel if the attestations field is set.

But looking at the rust-dlc code, I'm pretty sure this won't work. AFAICT, if we find a confirmed CET we are setting it to PreClosed (?!) and we are setting attestations to None.

It would be good to test this PR e2e, but for that we need #2378.

Originally posted by @luckysori in #2513 (comment)
@holzeis holzeis mentioned this issue May 9, 2024
Merged
@luckysori luckysori added the bug Something isn't working label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holzeis @luckysori