Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventually-postgres: crate documentation in eventually #117

Open
ar3s3ru opened this issue Oct 5, 2020 · 2 comments
Open

eventually-postgres: crate documentation in eventually #117

ar3s3ru opened this issue Oct 5, 2020 · 2 comments
Labels
documentation Improvements or additions to documentation eventually Issue or Pull Request involves eventually crate eventually-postgres Issue or Pull Request involves eventually-util crate

Comments

@ar3s3ru
Copy link
Collaborator

ar3s3ru commented Oct 5, 2020

The documentation for eventually-postgres is not visible in the public crate documentation.

As a result, users interested in using the Postgres EventStore implementation don't know how to.

From #116

@ar3s3ru ar3s3ru added documentation Improvements or additions to documentation eventually-postgres Issue or Pull Request involves eventually-util crate eventually Issue or Pull Request involves eventually crate labels Oct 5, 2020
@pseudo-su
Copy link

pseudo-su commented Oct 5, 2020

Just a thought, but I'd find it really useful to have a version of the example app that was easy to get running locally w/ a postgres event store. Going through the current docs I can't quite grok if/how a "real" app would need to think about things like schema migrations etc.

I think Ideally you'd be able to just docker-compose up the example app and then poke around in the postgres DB.

Something along these lines:

# .env
POSTGRES_USER=user
POSTGRES_PASSWORD=password
POSTGRES_DB=eventually-app-example-db
# docker-compose.yml
version: '3'
services:

  example_db:
    container_name: "example-db"
    image: "postgres"
    ports:
      - "5432:5432"
    env_file:
      - .env
    volumes:
      - database-data:/var/lib/postgresql/data/ # persist data even if container shuts down

  example_app:
    container_name: "example-app"
    build: .
    depends_on:
      - example_db
    ports:
      - "8080:8080"
    env_file:
      - .env
    
volumes:
  database-data:

@ar3s3ru
Copy link
Collaborator Author

ar3s3ru commented Oct 5, 2020

Hey @pseudo-su 👋

Yes, initially the example app was running using Postgres.

However, since it's hard to test many of the components in the crate,
I wrote integration tests targeting the example app to contribute to the overall crate coverage.

This means that, running integration tests now easily, both locally and on Github Actions, it's a tad more complicated.

I'll figure something out and use Postgres 😄


In general, however, I'd like to have documentation that is clear and bespoke enough for you not to poke around the example app too much to get up and running.

So that's definitely also part of documentation 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation eventually Issue or Pull Request involves eventually crate eventually-postgres Issue or Pull Request involves eventually-util crate
Projects
None yet
Development

No branches or pull requests

2 participants