From 8ea49651cdba53814a4f23eacf532cc5fa6e739d Mon Sep 17 00:00:00 2001
From: Gerrod Ubben <gerrodubben@gmail.com>
Date: Tue, 9 Jul 2024 17:36:24 -0400
Subject: [PATCH] Fix docker-compose add_signing_service script

fixes: #647
---
 CHANGES/647.bugfix                   | 1 +
 images/assets/add_signing_service.sh | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 100644 CHANGES/647.bugfix

diff --git a/CHANGES/647.bugfix b/CHANGES/647.bugfix
new file mode 100644
index 00000000..bf7186e6
--- /dev/null
+++ b/CHANGES/647.bugfix
@@ -0,0 +1 @@
+Fixed default docker compose file not launching when PULP_SIGNING_KEY_FINGERPRINT was unset.
diff --git a/images/assets/add_signing_service.sh b/images/assets/add_signing_service.sh
index c40b07b1..5a950424 100755
--- a/images/assets/add_signing_service.sh
+++ b/images/assets/add_signing_service.sh
@@ -3,7 +3,7 @@
 /usr/bin/wait_on_postgres.py
 /usr/bin/wait_on_database_migrations.sh
 
-if [ -n "${PULP_SIGNING_KEY_FINGERPRINT}" ]; then
+if [ -n "${PULP_SIGNING_KEY_FINGERPRINT-}" ]; then
   /usr/local/bin/pulpcore-manager add-signing-service "${COLLECTION_SIGNING_SERVICE}" /var/lib/pulp/scripts/collection_sign.sh "${PULP_SIGNING_KEY_FINGERPRINT}"
   /usr/local/bin/pulpcore-manager add-signing-service "${CONTAINER_SIGNING_SERVICE}" /var/lib/pulp/scripts/container_sign.sh "${PULP_SIGNING_KEY_FINGERPRINT}" --class container:ManifestSigningService
 fi