Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how printing map preview is managed #10831

Open
1 of 6 tasks
tdipisa opened this issue Feb 20, 2025 · 0 comments · May be fixed by #10866
Open
1 of 6 tasks

Improve how printing map preview is managed #10831

tdipisa opened this issue Feb 20, 2025 · 0 comments · May be fixed by #10866
Assignees
@mahmoudadel54
Labels
enhancement Print
Milestone
2025.01.00

Comments

@tdipisa
Copy link
Member

tdipisa commented Feb 20, 2025 •
edited by offtherailz
Loading

Description

Currently the printing preview map is always synchronized with the underling viewer's map which means that if you pan the viewer's map the printing preview map moves accordingly.
This makes sometime difficult to manage the printing preview, especially when the preview scale selector is present. In that case, indeed, if you select a scale from the scale selector and then you move the viewer's map, then the preview maps synchronizes loosing the scale previously selected.

map_preview.mp4

As part of this issue, we should detach the printing preview from the viewer's map providing the following:

  • The printing map preview is no longer synchronized with the viewer's map
  • The printing map preview can be moved and zoomed independently using the mouse wheel and/or the scale selector, if present.
  • When the user clicks on print, the final print will in fact use the center and scale (properly converted) on the map preview, with the result of printing the same viewport (the image may change in resolution because of the DPI selector).
  • The sync button in the preview map for manually synching the preview with the viewer's map remain available as is (if configured)

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information
@tdipisa tdipisa added this to the 2025.01.00 milestone Feb 20, 2025
@tdipisa tdipisa added the Print label Feb 20, 2025
@tdipisa tdipisa changed the title Improve how printing preview scales are managed Improve how printing map preview is managed Feb 20, 2025
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Feb 25, 2025
@mahmoudadel54
geosolutions-it#10831: Improve how printing map preview is managed
529e594 
Description:
- handling printing map preview is no longer synchronized with the viewer's map
- handling printing map preview can be moved and zoomed independently using the mouse wheel and/or the scale selector, if present
- enable the user to click on print, the final print will in fact use the center and scale (properly converted) on the map preview, with the result of printing the same viewport (the image may change in resolution because of the DPI selector)
- handling sync button in the preview map just for manually synching the preview with the viewer's map remain available as is (if configured)
- add unit test
@mahmoudadel54 mahmoudadel54 linked a pull request Feb 25, 2025 that will close this issue
Open
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Feb 25, 2025 that will close this issue
#10831: Improve how printing map preview is managed #10866
Open
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Feb 28, 2025
@mahmoudadel54
geosolutions-it#10831: Improve how printing map preview is managed
4b02b5c 
Description:
- in Print plugin, for mapPreviewOptions prop --> set 'enableRefresh' with true as a default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahmoudadel54 mahmoudadel54

Labels
enhancement Print
Projects
None yet
Milestone
2025.01.00
Development

Successfully merging a pull request may close this issue.

#10831: Improve how printing map preview is managed mahmoudadel54/MapStore2
2 participants
@tdipisa @mahmoudadel54