Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable identify popup in case of no results #10545

Open
1 of 6 tasks
tdipisa opened this issue Sep 16, 2024 · 0 comments · May be fixed by #10557
Open
1 of 6 tasks

Option to disable identify popup in case of no results #10545

tdipisa opened this issue Sep 16, 2024 · 0 comments · May be fixed by #10557
Assignees
Labels
BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C044-VLAANDEREN-2024-SUPPORT enhancement
Milestone

Comments

@tdipisa
Copy link
Member

tdipisa commented Sep 16, 2024

Description

It is requested a new configuration option to prevent the Identify popup from displaying in case of no results instead of showing the following:

image

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

  • we will need to add a new flag to the plugin for enabling this alternative behaviour
  • if this flag is true instead of returning this we will return null, see renderEmptyPages method
@tdipisa tdipisa added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C044-VLAANDEREN-2024-SUPPORT labels Sep 16, 2024
@tdipisa tdipisa added this to the 2024.02.01 milestone Sep 16, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 18, 2024
… results

Description:
- handle adding an option called 'hidePopupIfNoResults' to hide the identify popup
- add unit tests
- add jsdoc
@mahmoudadel54 mahmoudadel54 linked a pull request Sep 18, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C044-VLAANDEREN-2024-SUPPORT enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants