-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map plugin should not initizialize invalid maps #10448
Closed
1 task done
Comments
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this issue
Jul 2, 2024
5 tasks
5 tasks
tdipisa
added
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Oct 4, 2024
offtherailz
pushed a commit
that referenced
this issue
Oct 21, 2024
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this issue
Nov 5, 2024
Merged
5 tasks
Merged
5 tasks
tdipisa
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Nov 5, 2024
tdipisa
pushed a commit
that referenced
this issue
Nov 5, 2024
rmelarab-ngs
pushed a commit
to ngsllc/MapStore2
that referenced
this issue
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The Map plugin initializes all map configurations that are truthy and this includes also configuration like this one:
For example the
eventListeners
property is persisted when we reset a map configuration.It would be better to improve the if statement in the Map.jsx plugin to ensure only valid map configurations are initializing the component.
We could also remove the canRender state not used anymore
What kind of improvement you want to add? (check one with "x", remove the others)
Other useful information
The text was updated successfully, but these errors were encountered: