Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement changes in RFC 7946 #53

Closed
frewsxcv opened this issue Nov 7, 2016 · 4 comments
Closed

Implement changes in RFC 7946 #53

frewsxcv opened this issue Nov 7, 2016 · 4 comments

Comments

@frewsxcv
Copy link
Member

frewsxcv commented Nov 7, 2016

http://www.macwright.org/2016/11/07/the-geojson-ietf-standard.html
@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 7, 2016

https://tools.ietf.org/html/rfc7946

@frewsxcv frewsxcv mentioned this issue Dec 21, 2016
Closed
@michaelkirk michaelkirk mentioned this issue Apr 30, 2017
Closed
frewsxcv added a commit that referenced this issue May 2, 2017
@frewsxcv
Remove geojson::Crs.
c88adb6 
Fixes #34.

Part of #53.
@frewsxcv frewsxcv mentioned this issue May 2, 2017
Merged
bors bot added a commit that referenced this issue May 2, 2017
@bors
Merge #71
1e9abdf 
71: Remove `geojson::Crs`. r=frewsxcv
Fixes #34.

Part of #53.
@frewsxcv frewsxcv mentioned this issue Sep 17, 2018
Closed
@frewsxcv
Copy link
Member Author

frewsxcv commented May 7, 2019

We need to enforce that Polygons from the geo-type crate are oriented the right way when converted to Values, as per:

A linear ring MUST follow the right-hand rule with respect to the
area it bounds, i.e., exterior rings are counterclockwise, and
holes are clockwise.

https://tools.ietf.org/html/rfc7946#section-3.1.6

urschrei added a commit that referenced this issue May 7, 2019
@urschrei
First pass at creating correctly-oriented polygons.
460d914 
See #53
@urschrei urschrei mentioned this issue May 7, 2019
Open
@frafra
Copy link

frafra commented Dec 28, 2020

Right-hand rule is not enforced by the software at the moment, but it should: https://gis.stackexchange.com/a/259957/162589

@frewsxcv
Copy link
Member Author

Right-hand rule is not enforced by the software at the moment, but it should: https://gis.stackexchange.com/a/259957/162589

Yep, thanks for calling that out. An attempt at fixing this was done in #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frafra @frewsxcv