Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test_geodtest_geodesic_inverse12 S12 behavior #30

Open
stonylohr opened this issue Jan 23, 2021 · 1 comment
Open

fix test_geodtest_geodesic_inverse12 S12 behavior #30

stonylohr opened this issue Jan 23, 2021 · 1 comment

Comments

@stonylohr
Copy link
Contributor

This inverse test using GeodTest data currently requires an S12 tolerance of 30 billion to pass call cases. Fix geodesic behavior to return more reasonable values, then adjust the tolerance used by this test.
@stonylohr
Copy link
Contributor Author

I'll plan to look at this next, possibly including #31 in the same pass, depending on how closely they turn out to be related.

stonylohr added a commit to stonylohr/geographiclib-rs that referenced this issue Feb 8, 2021
@stonylohr
georust#30 part: geodtest inverse12 S12
76af3c6 
Assorted fixes.
Added test exception for GeodTest.dat line 400001 inverse12, which Karney's code fails identically to ours.
@michaelkirk michaelkirk mentioned this issue Feb 22, 2021
Merged
2 tasks
bors bot added a commit that referenced this issue Feb 22, 2021
@bors @stonylohr
Merge #41
0912caf 
41: #30 part: geodtest inverse12 S12 r=michaelkirk a=stonylohr

Assorted fixes.
Added test exception for GeodTest.dat line 400001 inverse12, which Karney's code fails identically to ours.

This one has been slower going.
There are clearly some remaining issues that should be addressed through further fixes in either main code or tests, one of which involves Lambda12 returning a value that differs at the 3rd significant digit for inputs that differ at the 13th digit or later. Other cases not yet explored at all. Anyway, I thought what I have so far was worth sharing. I can comment more in the coming days, but have to get going for now.

- [ ] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md).
- [ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---



Co-authored-by: Stony <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stonylohr