Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexform structure of eventRestriction has changed #101

Open
bribbelbum opened this issue Jul 3, 2020 · 2 comments · May be fixed by #159
Open

Flexform structure of eventRestriction has changed #101

bribbelbum opened this issue Jul 3, 2020 · 2 comments · May be fixed by #159

Comments

@bribbelbum
Copy link

bribbelbum commented Jul 3, 2020 •
edited
Loading

After update from eventnews from 3.0.0 to 4.0.0, the eventRestriction value is not preselected with the correct value. After analysing the problem, I found out that the flexfrom xml structure has changed. The eventRestriction is now in a sheet extraEntryEventNews.
If the plugin will be edit from an editor and forgot to set the value of eventRestriction new. The plugin does not work correct anymore in frontend.

Is an updatescript planned?
@SomeBdyElse
Copy link

I can confirm the issue with eventnews 5.0.1 in TYPO3 11 and a very old data set. If a TYPO3 backend editor edits an old news list plugin, the eventRestriction setting is ignored. The field always shows "Defined in TypoScript". If the editor saves the form, this incorrect setting is saved. If the editor picks "only events" or any other setting, the setting is persisted as it should.

It seems to me that there is an upgrade wizard missing, that would modify the pi_flexform xml and adapt it to the new position of the eventRestriction field.

SomeBdyElse added a commit to saccas/t3ext-eventnews that referenced this issue Mar 22, 2023
@SomeBdyElse
[BUGFIX] Implement update wizard for flexform changes
4ab1c68 
The tx_news plugin's flexform field 'settings.eventRestriction' was
moved to its own flexform sheet. Provide an update wizard to adapt the
flexform data in the tt_content rows accordingly.

Fixes: georgringer#101
@SomeBdyElse SomeBdyElse linked a pull request Mar 22, 2023 that will close this issue
Open
@SomeBdyElse
Copy link

@georgringer I added an update wizard that copies the data from the old eventRestriction field to the new one. If an editor already made conscious changes to the new eventRestriction field, those changes will be overridden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Implement update wizard for flexform changes saccas/t3ext-eventnews
2 participants
@SomeBdyElse @bribbelbum