Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Switch patching to use patchy #109

Open
cchoquette opened this issue Jul 29, 2019 · 1 comment
Open

Switch patching to use patchy #109

cchoquette opened this issue Jul 29, 2019 · 1 comment
Assignees
@cchoquette

Comments

@cchoquette
Copy link
Contributor

cchoquette commented Jul 29, 2019 •
edited by jzhang-gp
Loading

Description

https://pypi.org/project/patchy/
_fit from sklearn.pipeline.Pipeline.
Estimate: 1 day
@cchoquette cchoquette self-assigned this Jul 29, 2019
@cchoquette cchoquette mentioned this issue Aug 7, 2019
Merged
@cchoquette cchoquette reopened this Aug 8, 2019
@cchoquette
Copy link
Contributor Author

Not possible using the current patchy api.
This will replace the source pipeline._fit which is not what we want. We want our own version of the Pipeline (DynamicPipeline) that acts in its own way. Otherwise, when we patch, things that just use Pipeline will now break.
Will revisit when this becomes an issue with a different solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cchoquette cchoquette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cchoquette