Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download vuln DB not considering private registry options #4

Open
24mu13 opened this issue Nov 8, 2024 · 0 comments
Open

Download vuln DB not considering private registry options #4

24mu13 opened this issue Nov 8, 2024 · 0 comments

Comments

@24mu13
Copy link

24mu13 commented Nov 8, 2024

Congrats for the good work with this contrib version of the task!
BTW I think make sense to do a rebase on upstream since they implemented few things recently.

The retry mechanism you implemented (d87c310) does not consider the following options: db-repository, java-db-repository, checks-bundle-repository.

The only effective way as for now to workaround the aquasecurity#82 in fact is using public.ecr.aws as registry. This is working well, apart for the downloadVulnDb that could still fail for TOOMANYREQUESTS.

parameters:
  - name: privateRegistry
    type: string
    # see: https://github.com/aquasecurity/trivy/discussions/7538
    default: public.ecr.aws

steps:
  - task: trivy-contrib@1
    inputs:
      image: ${{ parameters.repositoryPrefix }}${{ imageName }}
      scanners: vuln
      ignoreUnfixed: true
      options: >
        --db-repository ${{ parameters.privateRegistry }}/aquasecurity/trivy-db
        --java-db-repository ${{ parameters.privateRegistry }}/aquasecurity/trivy-java-db 
        --checks-bundle-repository ${{ parameters.privateRegistry }}/aquasecurity/trivy-checks 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant