update tests

Author: tomkralidis

pycsw/ogc/api/records.py

@@ -337,13 +337,28 @@ def collections(self, headers_, args, collection=False):
             response = {
                 'collections': [collection_info]
             }
-        else:
-            response = collection_info
-
-        if not collection:
             template = 'collections.html'
+            url_base = f"{self.config['server']['url']}/collections"
         else:
+            response = collection_info
             template = 'collection.html'
+            url_base = f"{self.config['server']['url']}/collections/metadata:main"
+
+        is_html = headers_['Content-Type'] == 'text/html'
+
+        response['links'] = [{
+            'rel': 'self' if not is_html else 'alternate',
+            'type': 'application/json',
+            'title': 'This document as JSON',
+            'href': f"{url_base}?f=json",
+            'hreflang': self.config['server']['language']
+        }, {
+            'rel': 'self' if is_html else 'alternate',
+            'type': 'text/html',
+            'title': 'This document as HTML',
+            'href': f"{url_base}?f=html",
+            'hreflang': self.config['server']['language']
+        }]
 
         return self.get_response(200, headers_, template, response)
 
@@ -634,7 +649,7 @@ def record2json(record):
         record_dict['properties']['formats'] = [record.format]
 
     if record.keywords:
-        record_dict['keywords'] = [x for x in record.keywords.split(',')]
+        record_dict['properties']['keywords'] = [x for x in record.keywords.split(',')]
 
     if record.links:
         record_dict['associations'] = []

tests/unittests/oarec-default.cfg

@@ -29,7 +29,7 @@
 
 [server]
 home=/var/www/pycsw
-url=http://localhost/pycsw/csw.py
+url=http://localhost/pycsw/oarec
 mimetype=application/xml; charset=UTF-8
 encoding=UTF-8
 language=en-US

tests/unittests/test_oarec.py

@@ -1,6 +1,8 @@
 import json
 import os
 
+import pytest
+
 from pycsw.core.util import parse_ini_config
 from pycsw.ogc.api.records import API
 
@@ -14,15 +16,125 @@ def get_test_file_path(filename):
         return f'tests/unittests/{filename}'
 
 
-def test_landing_page():
+@pytest.fixture()
+def config():
+    return parse_ini_config(get_test_file_path('oarec-default.cfg'))
+
 
-    api_ = API(parse_ini_config(get_test_file_path('oarec-default.cfg')))
+@pytest.fixture()
+def api(config):
+    return API(config)
 
-    headers, status, content = api_.landing_page({}, {'f': 'json'})
+
+def test_landing_page(api):
+    headers, status, content = api.landing_page({}, {'f': 'json'})
     content = json.loads(content)
 
     assert headers['Content-Type'] == 'application/json'
     assert status == 200
     assert len(content['links']) == 10
 
-    headers, status, content = api_.landing_page({}, {'f': 'json'})
+    for link in content['links']:
+        assert link['href'].startswith(api.config['server']['url'])
+
+    headers, status, content = api.landing_page({}, {'f': 'html'})
+    assert status == 200
+    assert headers['Content-Type'] == 'text/html'
+
+
+def test_conformance(api):
+    content = json.loads(api.conformance({}, {})[2])
+
+    assert len(content['conformsTo']) == 6
+
+
+def test_collections(api):
+    content = json.loads(api.collections({}, {})[2])
+
+    assert len(content['links']) == 2
+    assert len(content['collections']) == 1
+
+    content = json.loads(api.collections({}, {}, True)[2])
+    assert len(content['links']) == 2
+    assert content['id'] == 'metadata:main'
+    assert content['title'] == 'pycsw Geospatial Catalogue'
+    assert content['description'] == 'pycsw is an OGC CSW server implementation written in Python'  # noqa
+    assert content['itemType'] == 'record'
+
+
+def test_queryables(api):
+    content = json.loads(api.queryables({}, {})[2])
+
+    assert content['type'] == 'object'
+    assert content['title'] == 'pycsw Geospatial Catalogue'
+    assert content['$id'] == 'http://localhost/pycsw/oarec/collections/metadata:main/queryables'  # noqa
+    assert content['$schema'] == 'http://json-schema.org/draft/2019-09/schema'
+
+    assert len(content['properties']) == 59
+
+
+def test_items(api):
+    content = json.loads(api.items({}, {})[2])
+
+    assert content['type'] == 'FeatureCollection'
+    assert len(content['links']) == 4
+    assert content['numberMatched'] == 12
+    assert content['numberReturned'] == 10
+    assert len(content['features']) == 10
+    assert len(content['features']) == content['numberReturned']
+
+    params = {'q': 'Lorem'}
+    content = json.loads(api.items({}, params)[2])
+    assert content['numberMatched'] == 5
+    assert content['numberReturned'] == 5
+    assert len(content['features']) == content['numberReturned']
+
+    params = {'bbox': '-50,0,50,80'}
+    content = json.loads(api.items({}, params)[2])
+    assert content['numberMatched'] == 3
+    assert content['numberReturned'] == 3
+    assert len(content['features']) == content['numberReturned']
+
+    params = {'bbox': '-50,0,50,80', 'q': 'Lorem'}
+    content = json.loads(api.items({}, params)[2])
+    assert content['numberMatched'] == 1
+    assert content['numberReturned'] == 1
+    assert len(content['features']) == content['numberReturned']
+
+    params = {'filter': 'title LIKE "%%Lorem%%"'}
+    content = json.loads(api.items({}, params)[2])
+    assert content['numberMatched'] == 2
+    assert content['numberReturned'] == 2
+    assert len(content['features']) == content['numberReturned']
+
+    params = {'filter': 'title LIKE "%%Lorem%%"', 'q': 'iPsUm'}
+    content = json.loads(api.items({}, params)[2])
+    assert content['numberMatched'] == 2
+    assert content['numberReturned'] == 2
+    assert len(content['features']) == content['numberReturned']
+
+    params = {'limit': 4}
+    content = json.loads(api.items({}, params)[2])
+    assert content['numberMatched'] == 12
+    assert content['numberReturned'] == 4
+    assert len(content['features']) == content['numberReturned']
+
+    params = {'limit': 4, 'startindex': 10}
+    content = json.loads(api.items({}, params)[2])
+    assert content['numberMatched'] == 12
+    assert content['numberReturned'] == 2
+    assert len(content['features']) == content['numberReturned']
+
+
+def test_item(api):
+    item = 'urn:uuid:19887a8a-f6b0-4a63-ae56-7fba0e17801f'
+    content = json.loads(api.item({}, {}, item)[2])
+
+    assert content['id'] == item
+    assert content['type'] == 'Feature'
+    assert content['properties']['title'] == 'Lorem ipsum'
+    assert content['properties']['keywords'] == ['Tourism--Greece']
+
+    item = 'urn:uuid:19887a8a-f6b0-4a63-ae56-7fba0e17801f'
+    params = {'f': 'xml'}
+    content = api.item({}, params, item)[2]