Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort and document containers #43

Open
2 tasks
m-weigand opened this issue Jul 29, 2018 · 0 comments
Open
2 tasks

Sort and document containers #43

m-weigand opened this issue Jul 29, 2018 · 0 comments
Labels
enhancement v0.2 Issues that should be fixed for v0.2

Comments

@m-weigand
Copy link
Contributor

m-weigand commented Jul 29, 2018

At this point it is not clear which container is used for what.

At the moment we have the following containers:

  • ERT: electrical resistivity data (magnitude)
  • sEIT: spectral electrical impedance data (spectral, complex, imaging)
  • SIP: spectral induced polarization data (spectral, complex)

complex=magnitude+phase|real+imag

I propose to add:

  • TDIP: (magnitude + time-domain decay data in the form of chargeabilities or decay curves)
  • CR: complex resistivity (single-frequency, complex, imaging)

Note 1: Perhaps we should design the ERT, TDIP, CR classes to that they inherit from each other in the order ERT -> TDIP -> CR. Thus, CR would contain all functionality contained on TDIP and ERT (however, certain functionality would be optional only in the case that chargeabilities are present).

In Theory this would also extend to the sEIT container, e.g. in the case were spectral data is recovered from TD-IP measurements. However, this would most probably be realized by means of some SIP-model such as the Cole-Cole model, and perhaps a new container would be appropriate once we want to support this.

Note 2: the TDIP and ERT would be closely related, and CR and sEIT. It would be a good idea to provide simple conversion functions.

Note 3: TDIP (i.e. chargeabilities) can be converted to CR (phase values) by using some approximations and analytical assumptions, which boils down to multiplying the integral chargeability by a factor (something like 1.5). However, I strongly suggest to make this conversion explicit (i.e. by the use of different container names and specific conversion functions).

@m-weigand m-weigand added enhancement v0.2 Issues that should be fixed for v0.2 labels Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement v0.2 Issues that should be fixed for v0.2
Projects
None yet
Development

No branches or pull requests

1 participant