Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with data #49

Open
strogonoff opened this issue Apr 26, 2024 · 7 comments
Open

Issues with data #49

strogonoff opened this issue Apr 26, 2024 · 7 comments

Comments

@strogonoff
Copy link
Contributor

strogonoff commented Apr 26, 2024

This concerns the main branch. I see there was a push yesterday, so it looks like it’s being actively worked on. In that case, here are some issues that break toolchains that work with that repository:

  • UUIDs within files don’t match UUIDs in filenames:
    Screenshot 2024-04-26 at 17 37 14
  • UUIDs between concepts & localized concepts don’t match (concepts must refer to correct UUIDs of localized concepts).
    This may be because concepts are referencing the UUID in filename, whereas some software (e.g., RegistryKit, etc.) references the id from within the file
  • Register items (at least localized concepts, I believe) are missing required top-level attribute status, which must be one of: valid, invalid, superseded, or retired. This means they are not recognized as register items by software that validates register contents more strictly

Minor issues—this does not break anything, but will cause unexpected diffs:

  • The initial document separator --- will be removed on data updates, because serializers that write register YAML treat each file as a standalone bare document (they do not allow multiple documents within one YAML file and intentionally do not support any directives)

cc @HassanAkbar @ronaldtse

@HassanAkbar
Copy link
Member

As @strogonoff mentioned

Register items (at least localized concepts, I believe) are missing required top-level attribute status, which must be one of: valid, invalid, superseded, or retired. This means they are not recognized as register items by software that validates register contents more strictly

@ronaldtse In the 20231214_Multi-Lingual_Glossary–Published__unlocked__withMath sheet, there is no status defined for some terms, what should be the status in that case? e.g concept id = 18 in Danish language does not have a status available.

@ronaldtse
Copy link
Member

@HassanAkbar if there are no status defined for those terms, just assume they are valid.

Ping @ReesePlews can we make that assumption? Thanks.

@ReesePlews
Copy link
Contributor

hello @HassanAkbar i guess if the non-english term does not exist the status is "valid" but "unpublished". with the "valid" status coming from the base english term and the "unpublished" coming from no translation from the Danish group being submitted. does this understanding make sense to everyone? @ronaldtse do you think this is an acceptable understanding?

Hassan, please send me a link and i will have a check. we are still working from the staging site, correct?

Question: earlier when you are talking about the UUIDs and such, this does not mean there will be a change in the api (json, rdf, turtle) links, correct?

@strogonoff
Copy link
Contributor Author

strogonoff commented May 13, 2024 via email

@strogonoff
Copy link
Contributor Author

strogonoff commented May 13, 2024 via email

@HassanAkbar
Copy link
Member

Question: earlier when you are talking about the UUIDs and such, this does not mean there will be a change in the api (json, rdf, turtle) links, correct?

@ReesePlews yes that is correct, the api will not be changed just values of the ids will be updated.

i guess if the non-english term does not exist the status is "valid" but "unpublished"

@ReesePlews The issue here is that the translation exists but it does not have a status attribute given in the excel file that is being used to generate the concepts.

By the explanation provided by you and @strogonoff I believe that it should be valid in that case.
Is this correct?

cc: @ronaldtse

@ronaldtse
Copy link
Member

Yes @HassanAkbar I believe this is the understanding. Thanks @ReesePlews @strogonoff !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants