Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map viewers #7

Open
martinRenou opened this issue Jun 13, 2024 · 5 comments
Open

Map viewers #7

martinRenou opened this issue Jun 13, 2024 · 5 comments
Labels
question Further information is requested
Milestone

Comments

@martinRenou
Copy link
Member

martinRenou commented Jun 13, 2024

It seems there are some choices on the front-end libs we can use:

We should make a decision on which one we pick by default.

We will design jupytergis so it can use different viewers (a couple of default viewers, viewers swap-able or new viewers through plugins)

@martinRenou martinRenou added the question Further information is requested label Jun 13, 2024
@davidbrochart
Copy link
Collaborator

We should also consider https://deck.gl.
The choice will probably depend on the needs of the project. While OpenLayers and LeafletJS should be similar for raster tiles, Maplibre should be more fit for vector tiles?

@martinRenou martinRenou added this to the 1.0.0 milestone Jun 19, 2024
@martinRenou martinRenou changed the title Which mapping library should we use? Map viewers Jun 19, 2024
@martinRenou
Copy link
Member Author

I edited the top comment

@brichet
Copy link
Collaborator

brichet commented Jun 20, 2024

That would be really nice.
Do you think we should be able to switch the viewer on the fly ? That would probably mean having some kind of viewer registry.

@martinRenou
Copy link
Member Author

martinRenou commented Jun 20, 2024

Indeed! We could do that.

I believe that, for the sake of simplicity, we'll start with maplibre-gl. But we should leave the door open to other viewers and allow switching on the fly. We should also provide the proper lumino tokens to allow extensions to provide their own viewers.

Viewers should implement the proper interface (addLayer(), removeLayer etc) so we can use them without really knowing what's under the hood.

@brichet
Copy link
Collaborator

brichet commented Jun 20, 2024

Agree with this.

The default layer should be a separate package that adds the default to the registry, like other extensions would do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants