Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save position/zoom explicitly #47

Open
davidbrochart opened this issue Jul 12, 2024 · 1 comment
Open

Save position/zoom explicitly #47

davidbrochart opened this issue Jul 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@davidbrochart
Copy link
Collaborator

Currently, every time a user pans or zooms the map, the new position and zoom are set into the shared model and eventually saved to file, but the UI doesn't react to these changes. It seems that this kind of information is rather related to the view, and each user has their own view of the map. But I agree that it can be useful to have it saved in the model too, so that it can be restored when the map is opened later.
Maybe a trade-off would be for the user to explicitly ask for it to be saved, with a button like "Save position/zoom"?

@martinRenou martinRenou added the enhancement New feature or request label Jul 12, 2024
@brichet
Copy link
Collaborator

brichet commented Sep 6, 2024

We discussed this with @martinRenou, and here are some ideas:

  • we could use the browser local storage to keep the position and zoom for each user
  • independently of saving the position in the shared document or not, the local storage will be the source of truth if it contains data
  • we could possibly add some landmarks in the shared model (which would be saved/loaded manually), and use one as default if there is no data in the local storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants