Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeodesicArea method names differ from Area and ChamberlainDuquetteArea #969

Open
JosiahParry opened this issue Dec 28, 2024 · 2 comments
Open

GeodesicArea method names differ from Area and ChamberlainDuquetteArea #969

JosiahParry opened this issue Dec 28, 2024 · 2 comments

Comments

@JosiahParry
Copy link
Contributor

The Area and ChamberlainDuquetteArea traits have methods with names signed_area() and unsigned_area() whereas the GeodesicArea trait has name area_signed() and area_unsigned(). It would be nice to have these renamed to be in line with the others
@kylebarron
Copy link
Member

This is taken directly from geo:

See chamberlain_duquette_signed_area and geodesic_area_signed.

I'm inclined to keep the API as similar to geo as possible. What do you think.

@JosiahParry
Copy link
Contributor Author

Ah good point! I agree. I'll make an issue there.

@JosiahParry JosiahParry mentioned this issue Dec 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JosiahParry @kylebarron