Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reading WKT using wkt crate #790

Closed
kylebarron opened this issue Sep 24, 2024 · 4 comments · Fixed by #892
Closed

Implement reading WKT using wkt crate #790

kylebarron opened this issue Sep 24, 2024 · 4 comments · Fixed by #892

Comments

@kylebarron
Copy link
Member

We can implement geo-traits on the WKT types here: https://docs.rs/wkt/latest/wkt/types/index.html

Then we can read WKT into GeoArrow without geozero using existing builder APIs.
@kylebarron kylebarron mentioned this issue Sep 24, 2024
Closed
@kylebarron
Copy link
Member Author

Partially closed by #791 , though the full parsing mechanism is not yet piped through

@kylebarron
Copy link
Member Author

Perhaps best to wait until georust/wkt#119 is in a wkt release

@michaelkirk
Copy link

We can release at any time - LMK if you want to wait for georust/wkt#120

@kylebarron
Copy link
Member Author

I don't think consensus is forthcoming in georust/wkt#120 so I would release sooner rather than later.

@kylebarron kylebarron mentioned this issue Dec 3, 2024
Merged
kylebarron added a commit that referenced this issue Dec 3, 2024
@kylebarron
Update wkt parser (#892)
29516f5 
- Update WKT parser to use the `wkt` crate directly instead of using
geozero
- Parses to an `UnknownGeometryArray`, so it allows geometries of
multiple dimensions.
- Updates Python implementation

Closes #790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update wkt parser geoarrow/geoarrow-rs
2 participants
@michaelkirk @kylebarron