Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs refer to non-public try_push method #257

Closed
JosiahParry opened this issue Nov 21, 2023 · 3 comments
Closed

Docs refer to non-public try_push method #257

JosiahParry opened this issue Nov 21, 2023 · 3 comments

Comments

@JosiahParry
Copy link
Contributor

Good chance I'm misinterpreting the doc. My reading of this is that one should prefer to use the try_push() method over the try_push_valid() and try_push_length() methods. However, there is not try_push() method.

https://github.com/geoarrow/geoarrow-rs/blob/8b1b15e43ac6468df10cc1c769694ec98c517d05/src/array/multipoint/mutable.rs#L168C28-L168C28

@kylebarron
Copy link
Member

Sorry, the docs in a large part of the codebase are not in a good state (copied originally from arrow2). The best way is just to follow the usage of first_pass and second_pass. Ideally with #260 you won't need to touch either.

@kylebarron
Copy link
Member

I'll close this assuming you can use the new vec blanket implementations. feel free to reopen if you need

@JosiahParry
Copy link
Contributor Author

Correct! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants