Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nic/stmmac: implement page_frag_alloc_align #12

Closed
trimpim opened this issue Sep 26, 2024 · 3 comments
Closed

nic/stmmac: implement page_frag_alloc_align #12

trimpim opened this issue Sep 26, 2024 · 3 comments

Comments

@trimpim
Copy link
Contributor

trimpim commented Sep 26, 2024

This method gets called when transferring data with scp.
trimpim added a commit to trimpim/genode-imx that referenced this issue Sep 26, 2024
@trimpim
stmmac_nic: implement page_frag_alloc_align
37f1b62 
This method gets called when transferring data with scp.

Issue gapfruit#2243
Issue genodelabs#12
@trimpim
Copy link
Contributor Author

trimpim commented Sep 26, 2024

I did take the implementation from nic/fec. maybe this could even be added to the global lx_emul

@chelmuth
Copy link
Member

chelmuth commented Sep 26, 2024 •
edited
Loading

You're right, we should consolidate the page_frag implementation. But in my opinion, we shall go for porting the original implementation from mm/page_alloc.c. It's only 3 C functions.

@skalk
Copy link
Member

skalk commented Nov 19, 2024 •
edited by chelmuth
Loading

@trimpim sorry I somehow missed this issue. The funtion was now implicitly implemented when enabling STMMAC on the MNT pocket. Thereby I mark this issue as solved. I've preserved the discussion in a separate issue in genodelabs/genode#5385

@skalk skalk closed this as completed Nov 19, 2024
@skalk skalk mentioned this issue Nov 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chelmuth @skalk @trimpim