Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker | Config: preprod network ID #45

Open
4TT1L4 opened this issue Nov 1, 2023 · 2 comments
Open

Docker | Config: preprod network ID #45

4TT1L4 opened this issue Nov 1, 2023 · 2 comments
Assignees
Labels
Configuration A change to config files, deployments and/or dependencies. Priority - Low Issue has low priority and has to be worked on after blocker and high issues T-Shirt size - Small High-Level effort estimation. Category "lowest effort".

Comments

@4TT1L4
Copy link
Contributor

4TT1L4 commented Nov 1, 2023

Problem:

  • Atlas and the Cardano Node take different network ID configuration, so we cannot pass the same value to both, which is making the configuration of these different modules a bit problematic.

Solution:

  • Make sure that we can pass the same network ID both to Atlas and the Cardano node, so we could easily configure both modules with the same configuration value.

Blocked by:

Related code lines:

{"coreProvider": { "socketPath": "/ipc/node.socket", "kupoUrl": "kupo:1442" }, "networkId": "testnet-preprod", "logging": [{ "type": { "tag": "stderr" }, "severity": "Info", "verbosity": "V2" }]}

environment: [NETWORK=preprod]

@4TT1L4 4TT1L4 self-assigned this Nov 1, 2023
@4TT1L4 4TT1L4 added Configuration A change to config files, deployments and/or dependencies. Priority - Low Issue has low priority and has to be worked on after blocker and high issues T-Shirt size - Small High-Level effort estimation. Category "lowest effort". labels Nov 1, 2023
@4TT1L4 4TT1L4 changed the title networkId: preprod Docker | Config: preprod network ID Nov 1, 2023
@4TT1L4
Copy link
Contributor Author

4TT1L4 commented Nov 1, 2023

Some changes must be done in the Atlas code, so it would accept the preprod string as a valid networkId.

After this change was incorporated into Atlas and it is released in the next official release, then we can update our docker-compose to pass the same string to both modules.

This is going to help us to keep the configuration more flexible and simple, so we could just pass the same string to both components, both to the cardano node and the atlas provider used by the SOR. At the moment this is not really critical, since the GY DEX is only on PREPROD testnet and not yet on MAINNET, but as soon as we need to be able to simply change between different networks, this little change is going to help us to keep the config simple.

@4TT1L4
Copy link
Contributor Author

4TT1L4 commented Nov 29, 2023

The related Atlas issue is closed. Now the preprod network ID is accepted by the most reccent Atlas version, so the preprod and mainnet network IDs could be used to configure both the Atlas backend provider and the Cardano Node, so the configuration switch between the different networks can be easily implemented.

Imprtant: We need to make sure to update the used Atlas revision to a version where the preprod network ID string is already supported.

Please see the following PR for the relevant Atlas changes:

Merged to the main branch of the Atlas repository on 2023-11-28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration A change to config files, deployments and/or dependencies. Priority - Low Issue has low priority and has to be worked on after blocker and high issues T-Shirt size - Small High-Level effort estimation. Category "lowest effort".
Projects
None yet
Development

No branches or pull requests

1 participant