update lint version + rules

Author: ichiriac

babel.config.js

@@ -1,11 +1,11 @@
-module.exports = function(api) {
+module.exports = function (api) {
   api.cache(true);
 
   const presets = ["@babel/preset-env"];
   const plugins = [];
 
   return {
     presets,
-    plugins
+    plugins,
   };
 };

jest.config.js

@@ -8,13 +8,16 @@ module.exports = {
   projects: [
     {
       displayName: "test",
-      testEnvironment: "node"
+      testEnvironment: "node",
     },
     {
       runner: "jest-runner-eslint",
       displayName: "lint",
       testMatch: ["<rootDir>/**/*.js"],
-      testPathIgnorePatterns: ["<rootDir>/node_modules/", "<rootDir>/coverage/"]
-    }
-  ]
+      testPathIgnorePatterns: [
+        "<rootDir>/node_modules/",
+        "<rootDir>/coverage/",
+      ],
+    },
+  ],
 };

src/ast.js

@@ -123,7 +123,7 @@ const Position = require("./ast/position");
  * @property {Boolean} withPositions - Should locate any node (by default false)
  * @property {Boolean} withSource - Should extract the node original code (by default false)
  */
-const AST = function(withPositions, withSource) {
+const AST = function (withPositions, withSource) {
   this.withPositions = withPositions;
   this.withSource = withSource;
 };
@@ -135,7 +135,7 @@ const AST = function(withPositions, withSource) {
  * @return {Position}
  * @private
  */
-AST.prototype.position = function(parser) {
+AST.prototype.position = function (parser) {
   return new Position(
     parser.lexer.yylloc.first_line,
     parser.lexer.yylloc.first_column,
@@ -165,23 +165,23 @@ AST.precedence = {};
   ["!"],
   ["instanceof"],
   ["cast", "silent"],
-  ["**"]
+  ["**"],
   // TODO: [ (array)
   // TODO: clone, new
-].forEach(function(list, index) {
-  list.forEach(function(operator) {
+].forEach(function (list, index) {
+  list.forEach(function (operator) {
     AST.precedence[operator] = index + 1;
   });
 });
 
-AST.prototype.isRightAssociative = function(operator) {
+AST.prototype.isRightAssociative = function (operator) {
   return operator === "**" || operator === "??";
 };
 
 /**
  * Change parent node informations after swapping childs
  */
-AST.prototype.swapLocations = function(target, first, last, parser) {
+AST.prototype.swapLocations = function (target, first, last, parser) {
   if (this.withPositions) {
     target.loc.start = first.loc.start;
     target.loc.end = last.loc.end;
@@ -197,7 +197,7 @@ AST.prototype.swapLocations = function(target, first, last, parser) {
 /**
  * Includes locations from first & last into the target
  */
-AST.prototype.resolveLocations = function(target, first, last, parser) {
+AST.prototype.resolveLocations = function (target, first, last, parser) {
   if (this.withPositions) {
     if (target.loc.start.offset > first.loc.start.offset) {
       target.loc.start = first.loc.start;
@@ -217,7 +217,7 @@ AST.prototype.resolveLocations = function(target, first, last, parser) {
 /**
  * Check and fix precence, by default using right
  */
-AST.prototype.resolvePrecedence = function(result, parser) {
+AST.prototype.resolvePrecedence = function (result, parser) {
   let buffer, lLevel, rLevel;
   // handling precendence
   if (result.kind === "call") {
@@ -349,14 +349,14 @@ AST.prototype.resolvePrecedence = function(result, parser) {
  * @param {Parser} parser - The parser instance (use for extracting locations)
  * @return {Function}
  */
-AST.prototype.prepare = function(kind, docs, parser) {
+AST.prototype.prepare = function (kind, docs, parser) {
   let start = null;
   if (this.withPositions || this.withSource) {
     start = this.position(parser);
   }
   const self = this;
   // returns the node
-  const result = function() {
+  const result = function () {
     let location = null;
     const args = Array.prototype.slice.call(arguments);
     args.push(docs);
@@ -405,7 +405,7 @@ AST.prototype.prepare = function(kind, docs, parser) {
     }
     AST.stack[++AST.stackUid] = {
       position: start,
-      stack: new Error().stack.split("\n").slice(3, 5)
+      stack: new Error().stack.split("\n").slice(3, 5),
     };
     result.stackUid = AST.stackUid;
   }
@@ -414,7 +414,7 @@ AST.prototype.prepare = function(kind, docs, parser) {
    * Sets a list of trailing comments
    * @param {*} docs
    */
-  result.setTrailingComments = function(docs) {
+  result.setTrailingComments = function (docs) {
     if (result.instance) {
       // already created
       result.instance.setTrailingComments(docs);
@@ -426,7 +426,7 @@ AST.prototype.prepare = function(kind, docs, parser) {
   /**
    * Release a node without using it on the AST
    */
-  result.destroy = function(target) {
+  result.destroy = function (target) {
     if (docs) {
       // release current docs stack
       if (target) {
@@ -446,7 +446,7 @@ AST.prototype.prepare = function(kind, docs, parser) {
   return result;
 };
 
-AST.prototype.checkNodes = function() {
+AST.prototype.checkNodes = function () {
   const errors = [];
   for (const k in AST.stack) {
     if (AST.stack.hasOwnProperty(k)) {
@@ -560,8 +560,8 @@ AST.prototype.checkNodes = function() {
   require("./ast/variadic"),
   require("./ast/while"),
   require("./ast/yield"),
-  require("./ast/yieldfrom")
-].forEach(function(ctor) {
+  require("./ast/yieldfrom"),
+].forEach(function (ctor) {
   AST.prototype[ctor.kind] = ctor;
 });
 

src/ast/classconstant.js

@@ -35,7 +35,7 @@ const ClassConstant = ConstantStatement.extends(KIND, function ClassConstant(
  * @param {Integer[]} flags
  * @return {void}
  */
-ClassConstant.prototype.parseFlags = function(flags) {
+ClassConstant.prototype.parseFlags = function (flags) {
   if (flags[0] === -1) {
     this.visibility = IS_UNDEFINED;
   } else if (flags[0] === null) {

src/ast/declaration.js

@@ -34,7 +34,7 @@ const Declaration = Statement.extends(KIND, function Declaration(
  * @param {Integer[]} flags
  * @return {void}
  */
-Declaration.prototype.parseFlags = function(flags) {
+Declaration.prototype.parseFlags = function (flags) {
   this.isAbstract = flags[2] === 1;
   this.isFinal = flags[2] === 2;
   if (this.kind !== "class") {

src/ast/location.js

@@ -12,7 +12,7 @@
  * @property {Position} start
  * @property {Position} end
  */
-const Location = function(source, start, end) {
+const Location = function (source, start, end) {
   this.source = source;
   this.start = start;
   this.end = end;

src/ast/node.js

@@ -27,14 +27,14 @@ const Node = function Node(kind, docs, location) {
  * Attach comments to current node
  * @param {*} docs
  */
-Node.prototype.setTrailingComments = function(docs) {
+Node.prototype.setTrailingComments = function (docs) {
   this.trailingComments = docs;
 };
 
 /**
  * Destroying an unused node
  */
-Node.prototype.destroy = function(node) {
+Node.prototype.destroy = function (node) {
   if (!node) {
     throw new Error(
       "Node already initialized, you must swap with another node"
@@ -67,7 +67,7 @@ Node.prototype.destroy = function(node) {
  * Includes current token position of the parser
  * @param {*} parser
  */
-Node.prototype.includeToken = function(parser) {
+Node.prototype.includeToken = function (parser) {
   if (this.loc) {
     if (this.loc.end) {
       this.loc.end.line = parser.lexer.yylloc.last_line;
@@ -90,7 +90,7 @@ Node.prototype.includeToken = function(parser) {
  * @param {Function} constructor
  * @return {Function}
  */
-Node.extends = function(type, constructor) {
+Node.extends = function (type, constructor) {
   constructor.prototype = Object.create(this.prototype);
   constructor.extends = this.extends;
   constructor.prototype.constructor = constructor;

src/ast/position.js

@@ -12,7 +12,7 @@
  * @property {Number} column
  * @property {Number} offset
  */
-const Position = function(line, column, offset) {
+const Position = function (line, column, offset) {
   this.line = line;
   this.column = column;
   this.offset = offset;

src/ast/propertystatement.js

@@ -36,7 +36,7 @@ const PropertyStatement = Statement.extends(KIND, function PropertyStatement(
  * @param {Integer[]} flags
  * @return {void}
  */
-PropertyStatement.prototype.parseFlags = function(flags) {
+PropertyStatement.prototype.parseFlags = function (flags) {
   if (flags[0] === -1) {
     this.visibility = IS_UNDEFINED;
   } else if (flags[0] === null) {

src/ast/typereference.js

@@ -34,7 +34,7 @@ TypeReference.types = [
   "array",
   "callable",
   "iterable",
-  "void"
+  "void",
 ];
 
 module.exports = TypeReference;

src/index.js

@@ -66,7 +66,7 @@ function combine(src, to) {
  * @property {AST} ast
  * @property {Object} tokens
  */
-const engine = function(options) {
+const engine = function (options) {
   if (typeof this === "function") {
     return new this(options);
   }
@@ -109,7 +109,7 @@ const engine = function(options) {
  * @param  {Buffer|String} buffer Input value that can be either a buffer or a string
  * @return {String}   Returns the string from input
  */
-const getStringBuffer = function(buffer) {
+const getStringBuffer = function (buffer) {
   return Buffer.isBuffer(buffer) ? buffer.toString() : buffer;
 };
 
@@ -119,15 +119,15 @@ const getStringBuffer = function(buffer) {
  * @return {Engine}
  * @private
  */
-engine.create = function(options) {
+engine.create = function (options) {
   return new engine(options);
 };
 
 /**
  * Evaluate the buffer
  * @private
  */
-engine.parseEval = function(buffer, options) {
+engine.parseEval = function (buffer, options) {
   const self = new engine(options);
   return self.parseEval(buffer);
 };
@@ -137,7 +137,7 @@ engine.parseEval = function(buffer, options) {
  * @param {String} buffer
  * @return {Program}
  */
-engine.prototype.parseEval = function(buffer) {
+engine.prototype.parseEval = function (buffer) {
   this.lexer.mode_eval = true;
   this.lexer.all_tokens = false;
   buffer = getStringBuffer(buffer);
@@ -148,7 +148,7 @@ engine.prototype.parseEval = function(buffer) {
  * Static function that parse a php code with open/close tags
  * @private
  */
-engine.parseCode = function(buffer, filename, options) {
+engine.parseCode = function (buffer, filename, options) {
   if (typeof filename === "object" && !options) {
     // retro-compatibility
     options = filename;
@@ -178,7 +178,7 @@ engine.parseCode = function(buffer, filename, options) {
  * @param {String} filename - Filename
  * @return {Program}
  */
-engine.prototype.parseCode = function(buffer, filename) {
+engine.prototype.parseCode = function (buffer, filename) {
   this.lexer.mode_eval = false;
   this.lexer.all_tokens = false;
   buffer = getStringBuffer(buffer);
@@ -189,7 +189,7 @@ engine.prototype.parseCode = function(buffer, filename) {
  * Split the buffer into tokens
  * @private
  */
-engine.tokenGetAll = function(buffer, options) {
+engine.tokenGetAll = function (buffer, options) {
   const self = new engine(options);
   return self.tokenGetAll(buffer);
 };
@@ -200,7 +200,7 @@ engine.tokenGetAll = function(buffer, options) {
  * @param {String} buffer
  * @return {String[]} - Each item can be a string or an array with following informations [token_name, text, line_number]
  */
-engine.prototype.tokenGetAll = function(buffer) {
+engine.prototype.tokenGetAll = function (buffer) {
   this.lexer.mode_eval = false;
   this.lexer.all_tokens = true;
   buffer = getStringBuffer(buffer);