Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit is additive? #3

Open
stabl-gjn opened this issue Aug 27, 2024 · 1 comment
Open

Limit is additive? #3

stabl-gjn opened this issue Aug 27, 2024 · 1 comment

Comments

@stabl-gjn
Copy link

This might just be a misunderstanding from my side but the limit is accumulated when not used, meaning if there are no requests for hours a big burst of requests exceeding the set limit would be valid (basically token accumulate and unspent tokens can be "saved" for later).

I would have imaged this limit to be "static", meaning it just being reset after the timeout with there being no way to accumulate unspent tokens.

I think both are valid options so please correct me if this library is not intended for the second use case.

I would be happy to contribute, just let me know 😊

@gengteng
Copy link
Owner

Thank you so much for your interest in this repository! Initially, this axum-limit crate was created mainly for educational purposes. However, I’m thrilled to see your enthusiasm for this project. If you're willing to contribute and help make it truly functional, that would be absolutely fantastic! 😊

Looking forward to your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants