made github account a first-class parameter #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if you still need accounts @kltm , but this is the right change to fix geneontology/termgenie#98 with other fixes.
|
I don't understand what you're doing here, is this an agreed upon change to the schema? We need to decide whether github and other accounts are top level or not. But it shouldn't be in both places. |
|
Definitely doesn't need to be in both places but I don't know the history of the schema. Was just trying to quickly fix the termgenie code. However, if you think that this will violate it, I can definitely work around it. Just let me know.
Nathan
… On Nov 28, 2016, at 10:25 PM, Chris Mungall ***@***.***> wrote:
I don't understand what you're doing here, is this an agreed upon change to the schema? We need to decide whether github and other accounts are top level or not. But it shouldn't be in both places.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
well it's already violating the schema, hence the travis err I think the code will have to be fixed to do the lookup in the accounts object |
|
No problem. Please close it then.
Nathan
… On Nov 28, 2016, at 11:00 PM, Chris Mungall ***@***.***> wrote:
well it's already violating the schema, hence the travis err
I think the code will have to be fixed to do the lookup in the accounts object
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Talked to @cmungall and decided not to do it this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you still need accounts @kltm , but this is the right change to fix geneontology/termgenie#98 with other fixes.