Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't close subscription on error #475

Closed
rpiaggio opened this issue Feb 27, 2023 · 1 comment
Closed

Don't close subscription on error #475

rpiaggio opened this issue Feb 27, 2023 · 1 comment

Comments

@rpiaggio
Copy link
Collaborator

Upon receiving an error message on a subscription, we are currently terminating it.

This goes contrary to the spec.

The way around this would be to provide a Stream[Either[Error, A]] instead of a Stream[A]. Actually, it'd be nice to have methods that support both.
@rpiaggio rpiaggio mentioned this issue Mar 4, 2023
Merged
@rpiaggio
Copy link
Collaborator Author

rpiaggio commented Mar 7, 2023

Addressed by #480

@rpiaggio rpiaggio closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rpiaggio