Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set field data types correctly while loading oq-engine outputs #713

Merged
merged 10 commits into from
Dec 16, 2019

Conversation

ptormene
Copy link
Member

Fixes #712

While doing this I made also some refactoring to reduce duplication in methods that add attributes to layers and methods that retrieve field names and types.
I also removed QgsExpression.quotedColumnRef where it was not needed. I am still using it in expressions for rule-based classification, to properly quote field names inside the expression, but it is not needed otherwise.
I made changes to a dozen of files, so I have to be careful that everything still works properly.
In some cases I am assuming that fields are numeric, but I still have to double-check that it is true in those cases.

@ptormene ptormene merged commit 7a91a0c into master Dec 16, 2019
@ptormene ptormene deleted the field-types branch December 16, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the correct data type when creating attributes while reading oq-engine outputs
1 participant