Set field data types correctly while loading oq-engine outputs #713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712
While doing this I made also some refactoring to reduce duplication in methods that add attributes to layers and methods that retrieve field names and types.
I also removed QgsExpression.quotedColumnRef where it was not needed. I am still using it in expressions for rule-based classification, to properly quote field names inside the expression, but it is not needed otherwise.
I made changes to a dozen of files, so I have to be careful that everything still works properly.
In some cases I am assuming that fields are numeric, but I still have to double-check that it is true in those cases.