Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct data type when creating attributes while reading oq-engine outputs #712

Open
ptormene opened this issue Dec 12, 2019 · 1 comment · Fixed by #713
Open
Assignees

Comments

@ptormene
Copy link
Member

By mistake, all attributes were created as numeric. QGIS allows to insert strings into numeric attributes, which remain valid and usable until you save them, then they are silently converted into numbers. As a consequence, when you consolidate the project, you lose the original strings.
We need to create attributes with proper types. Types might be read from the extracted data, checking the corresponding dtype.

@ptormene
Copy link
Member Author

Although in many cases it is true that all fields are numeric, it is risky also in those cases to force the conversion of all values to float. I have to review all cases and read values considering the actual input data types.

@ptormene ptormene reopened this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant