Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to catch2 version 3.2.0 #45

Open
joakimwennergren opened this issue Nov 22, 2022 · 2 comments
Open

Upgrade to catch2 version 3.2.0 #45

joakimwennergren opened this issue Nov 22, 2022 · 2 comments

Comments

@joakimwennergren
Copy link

Describe the bug
Not really a bug but an improvement: upgrade catch2 depdency to look for 3.2.0 latest stable.

To Reproduce
cmake add_subdirectory and get warning that catch2 version 2.10 is needed when recently running brew install catch2 which will install 3.2.0 stable.

Expected behavior
get no error/warning.

Build:

  • compiler: Apple clang version 14.0.0 (clang-1400.0.29.202)
  • Link type: static
  • Any specific flags: no

Additional context
find_package(Catch2 3.2.0 REQUIRED) in CmakeLists.txt should do it.

@gelldur
Copy link
Owner

gelldur commented Nov 24, 2022

Thank you, I will upgrade but need to fix CI pipeline first. For now you may just build without tests.

option(ENABLE_TEST "Enable test" ON)

I may consider to turn it off by default. What do you think? Normally when someone uses lib want fast and easy build I think.

@joakimwennergren
Copy link
Author

Thank you, I will upgrade but need to fix CI pipeline first. For now you may just build without tests.

option(ENABLE_TEST "Enable test" ON)

I may consider to turn it off by default. What do you think? Normally when someone uses lib want fast and easy build I think.

Yes i also think turning it off by default is the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants