From 2a24ae4425fc97eab06c8d23a2fadb4c08c42b00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mert=20=C3=87=C4=B1kla?= <58304245+Ciklamert@users.noreply.github.com> Date: Mon, 7 Oct 2024 19:02:36 +0300 Subject: [PATCH 1/3] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md index 83f0e04f..0e412cd7 100644 --- a/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md @@ -2,7 +2,7 @@ Before submitting your pull request, ensure the following: ### Pull Request Title Standard -- [ ] The pull request title follows the standard: [Pull Request Naming Conventions](https://github.com/gelecekbilimde/gelecekbilimde-backend/blob/main/CONTRIBUTING.md#pull-request-title-standard). +- [ ] The pull request title follows the standard: [Pull Request Naming Conventions](https://github.com/gelecekbilimde/backend/blob/main/CONTRIBUTING.md#pull-request-naming-conventions)). ### Local Testing - [ ] I have tested my changes locally on Postman, and they are working as expected. From 214d74fcaca0357efce687d44b7d832eea2424c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mert=20=C3=87=C4=B1kla?= <58304245+Ciklamert@users.noreply.github.com> Date: Mon, 7 Oct 2024 19:02:52 +0300 Subject: [PATCH 2/3] Delete PULL_REQUEST_TEMPLATE.md --- PULL_REQUEST_TEMPLATE.md | 21 --------------------- 1 file changed, 21 deletions(-) delete mode 100644 PULL_REQUEST_TEMPLATE.md diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md deleted file mode 100644 index 44bd9aa6..00000000 --- a/PULL_REQUEST_TEMPLATE.md +++ /dev/null @@ -1,21 +0,0 @@ -## Pull Request Checklist -Before submitting your pull request, ensure the following: - -### Title and Branch Naming Conventions: -* The pull request title follows the standard: Pull Request Naming Conventions. -* The branch name follows one of the conventions outlined in the Branch Naming Conventions. - -### Local Testing: - * I have tested my changes locally using Postman, and they are working as expected. - -### Code Quality: -* The code is formatted according to the project's coding guidelines and style. -* The code has been reviewed to ensure its quality. -* The code does not contain any issues flagged by SonarLint. - -### Documentation: -* Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman. - -### Reviewers and Assignees: -* Default reviewers have been assigned to this pull request. -* Assignees have been added if necessary. From 21ac85cd4c86d3f00346ce1043164b07af46d3d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mert=20=C3=87=C4=B1kla?= <58304245+Ciklamert@users.noreply.github.com> Date: Mon, 7 Oct 2024 19:03:42 +0300 Subject: [PATCH 3/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e056d22d..76e820e2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -226,9 +226,6 @@ To maintain a consistent commit history, start your commit messages with a keywo - `#2 | imp: Added timestamp to API responses` - `#3 | fix: Resolved permission error when editing user's comment` - ### Pull Request Title Standard -- For pull requests, include the issue number and a brief description of the change: -- Use # | prefix followed by the commit type and a concise description. ## API Response Examples