Report the number of times a feature is used as a metric #8342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only report how many branches it is used in total. Also report how many branches have their schemas introspected currently. This is helpful here because we only get feature count info from introspected branches.
elprans
approved these changes
Feb 15, 2025
zackelan
approved these changes
Feb 15, 2025
edb/server/metrics.py
Outdated
| 'feature_used_branch_count_current', | ||
| 'How many branches a schema feature is used by.', | ||
| labels=('tenant', 'feature'), | ||
| ) | ||
| feature_used = registry.new_labeled_gauge( | ||
| 'feature_used_num_count_current', | ||
| 'How many branches a schema feature is used by.', |
There was a problem hiding this comment.
can you update this description so it's not the same as the other one?
deepbuzin
pushed a commit
that referenced
this pull request
Feb 18, 2025
Currently we only report how many branches it is used in total. Also report how many branches have their schemas introspected currently. This is helpful here because we only get feature count info from introspected branches.
msullivan
added
backported-6.x
msullivan
added a commit
that referenced
this pull request
Feb 21, 2025
Currently we only report how many branches it is used in total. Also report how many branches have their schemas introspected currently. This is helpful here because we only get feature count info from introspected branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only report how many branches it is used in total.
Also report how many branches have their schemas introspected
currently. This is helpful here because we only get feature count
info from introspected branches.