Try doing retries in test_ext_ai_indexing_02 #8325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
reviewed
Feb 10, 2025
tests/test_ext_ai.py
Outdated
| timeout=30.0, | ||
| ): | ||
| async with tr: | ||
| try: |
There was a problem hiding this comment.
Do we need this extra try/except wrapping?
There was a problem hiding this comment.
Definitely makes it easier to find this particular error.
The more general fix is that assert_query_result ought to do retries when not in a transaction, of course, but let's try to get this release out.
msullivan
force-pushed
the
ai-retry-loop
branch
from
60b4442 to
6ed1b75
Compare
scotttrinh
approved these changes
Feb 10, 2025
deepbuzin
pushed a commit
that referenced
this pull request
Feb 18, 2025
The more general fix is that assert_query_result ought to do retries when not in a transaction, of course, but let's try to get this release out. This is a forward-port from something already on the 6.x branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more general fix is that assert_query_result ought to do retries
when not in a transaction, of course, but let's try to get this
release out.
This is a forward-port from something already on the 6.x branch.